Skip to contentSkip to conversation

Fix bad apic fix on i386

PATCH New Andi Kleen 1 participant 1 message Feb 7, 2006

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 Fix bad apic fix on i386

Fix wrong ! in bad apic fix

I forget to remove the ! when moving the code from x86-64 to i386 x86-64 tested !disable_apic, but of course for cpu_has_apic it shouldn't be negated.

Credit goes to Jan Beulich for spotting it with eagle eyes.

Cc jbeulich@novell
arch/i386/kernel/apic.c +1 -1
Index: linux/arch/i386/kernel/apic.c
===================================================================
@@ -77,7 +77,7 @@ void ack_bad_irq(unsigned int irq)
 	 * completely.
 	 * But only ack when the APIC is enabled -AK
 	 */
-	if (!cpu_has_apic)
+	if (cpu_has_apic)
 		ack_APIC_irq();
 }