Skip to contentSkip to conversation

missing includes in drivers/net/mv643xx_eth.c

PATCH In review Al Viro 3 participants 3 messages Feb 8, 2006

Subsystems (2)
lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 4/29 missing includes in drivers/net/mv643xx_eth.c

Date: 1137630954 -0500

---

 drivers/net/mv643xx_eth.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

b6298c22c5e9f698812e2520003ee178aad50c10

drivers/net/mv643xx_eth.c +2 -0
index 7ef4b04..c0998ef 100644
@@ -32,6 +32,8 @@
  */
 #include <linux/init.h>
 #include <linux/dma-mapping.h>
+#include <linux/in.h>
+#include <linux/ip.h>
 #include <linux/tcp.h>
 #include <linux/udp.h>
 #include <linux/etherdevice.h>
Signature · 1 line
0.99.9.GIT
#2 lore raw

PATCH 1/1 mv643xx_eth: remove repeated includes of linux/in.h and linux/ip.h

In reply to Al Viro

From: Dale Farnsworth <[email protected]>

---

These includes were added twice:
in commit 78a5e534758349fd3effc90ce1152b55368f52ee by Olaf Hering and in commit b6298c22c5e9f698812e2520003ee178aad50c10 by Al Viro. This patch reverts 78a5e534758349fd3effc90ce1152b55368f52ee.

They probably should have been included before linux/tcp.h in the first place.

 drivers/net/mv643xx_eth.c |    2 --
 1 file changed, 2 deletions(-)
drivers/net/mv643xx_eth.c +0 -2
Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c
===================================================================
@@ -37,8 +37,6 @@
 #include <linux/tcp.h>
 #include <linux/udp.h>
 #include <linux/etherdevice.h>
-#include <linux/in.h>
-#include <linux/ip.h>
 
 #include <linux/bitops.h>
 #include <linux/delay.h>