Skip to contentSkip to conversation

asm-powerpc/highmem.h missing

DISCUSSION Olaf Hering 3 participants 6 messages Feb 8, 2006 – Feb 9, 2006

lore
Share & tools
lore
#0 lore raw

Why was asm-ppc/highmem.h not migrated? linux/highmem.h and pagemap.h wants it.

Signature · 2 lines
short story of a lazy sysadmin:
 alias appserv=wotan
#1 lore raw
Quoted 3 lines · On Wed, 8 Feb 2006 10:34:39 +0100 Olaf Hering <[email protected]> wrote:

Why was asm-ppc/highmem.h not migrated? linux/highmem.h and pagemap.h wants it.

I guess it was not migrated because it is only required for CONFIG_HIGHMEM and, of course, ppc64 does not need HIGHMEM and presumably noone has tried to build with CONFIG_HIGHMEM set in ARCH=powerpc until now.

Patches accepted :-)

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#2 lore raw
Quoted 8 lines · Stephen Rothwell
Quoted 3 lines · On Wed, 8 Feb 2006 10:34:39 +0100 Olaf Hering <[email protected]> wrote:

Why was asm-ppc/highmem.h not migrated? linux/highmem.h and pagemap.h wants it.

I guess it was not migrated because it is only required for CONFIG_HIGHMEM and, of course, ppc64 does not need HIGHMEM and presumably noone has tried to build with CONFIG_HIGHMEM set in ARCH=powerpc until now.

Well, thats not really true, ppc32 builds/works just fine with that, if you want to use more than 768MB.
The quickcam kernel module did include pagemap.h, but it works just fine without it. So nothing needs to be changed in the kernel.

Signature · 2 lines
short story of a lazy sysadmin:
 alias appserv=wotan
#3 lore raw
In reply to Stephen Rothwell
Quoted 8 lines · Stephen Rothwell
Quoted 3 lines · On Wed, 8 Feb 2006 10:34:39 +0100 Olaf Hering <[email protected]> wrote:

Why was asm-ppc/highmem.h not migrated? linux/highmem.h and pagemap.h wants it.

I guess it was not migrated because it is only required for CONFIG_HIGHMEM and, of course, ppc64 does not need HIGHMEM and presumably noone has tried to build with CONFIG_HIGHMEM set in ARCH=powerpc until now.

zaptel wants it as well, via netdevice.h/skbuff.h. I wonder why 32bit compiles anyway, given the many users of linux/highmem.h. Looking...

Argh, still these hacks:

lrwxrwxrwx 1 olaf users 64 2006-02-04 13:16 arch/powerpc/include/asm -> /home/olaf/kernel/olh/ppc64/linux-2.6.16-rc2-olh/include/asm-ppc/

So better move it over quick.

Signature · 2 lines
short story of a lazy sysadmin:
 alias appserv=wotan
#4 lore raw
Quoted 17 lines · Olaf Hering
Quoted 8 lines · Stephen Rothwell
Quoted 3 lines · On Wed, 8 Feb 2006 10:34:39 +0100 Olaf Hering <[email protected]> wrote:

Why was asm-ppc/highmem.h not migrated? linux/highmem.h and pagemap.h wants it.

I guess it was not migrated because it is only required for CONFIG_HIGHMEM and, of course, ppc64 does not need HIGHMEM and presumably noone has tried to build with CONFIG_HIGHMEM set in ARCH=powerpc until now.

zaptel wants it as well, via netdevice.h/skbuff.h. I wonder why 32bit compiles anyway, given the many users of linux/highmem.h. Looking...

Quoted 6 lines

Argh, still these hacks:

lrwxrwxrwx 1 olaf users 64 2006-02-04 13:16 arch/powerpc/include/asm -> /home/olaf/kernel/olh/ppc64/linux-2.6.16-rc2-olh/include/asm-ppc/

So better move it over quick.

You do realize there are a slew of headers in include/asm-ppc/ that we use in the arch/powerpc builds for ppc32.

- kumar

#5 lore raw
Quoted 2 lines · Kumar Gala

You do realize there are a slew of headers in include/asm-ppc/ that we use in the arch/powerpc builds for ppc32.

Yes, I just realized that I have to patch both asm/io.h files. ARGH!

Signature · 2 lines
short story of a lazy sysadmin:
 alias appserv=wotan