Skip to contentSkip to conversation

arch/x86_common: more formal reuse of i386+x86_64 source code

PATCH/RFC Randy.Dunlap 4 participants 6 messages Feb 9, 2006 – Feb 22, 2006

lore
Share & tools
lore
#0 lore raw

(not completed yet)
(patch applies to 2.6.16-rc2)

Patch is 331 KB and is at
http://www.xenotime.net/linux/patches/x86-common1.patch

From: Randy Dunlap <[email protected]>

Move lots of i386 & x86_64 common code into arch/x86_common/ and modify Makefiles to use it from there.

---
 arch/i386/boot/edd.S                         |  176 --
 arch/i386/boot/setup.S                       |    2
 arch/i386/kernel/Makefile                    |    8
 arch/i386/kernel/bootflag.c                  |   99 -
 arch/i386/kernel/cpu/Makefile                |    2
 arch/i386/kernel/cpu/intel_cacheinfo.c       |  655 ---------
 arch/i386/kernel/cpuid.c                     |  245 ---
 arch/i386/kernel/dmi_scan.c                  |  301 ----
 arch/i386/kernel/early_printk.c              |    2
 arch/i386/kernel/i8237.c                     |   67
 arch/i386/kernel/microcode.c                 |  516 -------
 arch/i386/kernel/msr.c                       |  326 ----
 arch/i386/kernel/quirks.c                    |   51
 arch/i386/mm/Makefile                        |    2
 arch/i386/mm/hugetlbpage.c                   |  289 ----
 arch/i386/pci/Makefile                       |   10
 arch/i386/pci/acpi.c                         |   68
 arch/i386/pci/common.c                       |  261 ---
 arch/i386/pci/direct.c                       |  289 ----
 arch/i386/pci/fixup.c                        |  467 ------
 arch/i386/pci/i386.c                         |  295 ----
 arch/i386/pci/irq.c                          | 1199 -----------------
 arch/i386/pci/legacy.c                       |   56
 arch/i386/pci/pci.h                          |   83 -
 arch/x86_64/boot/setup.S                     |    2
 arch/x86_64/kernel/Makefile                  |   16
 arch/x86_64/kernel/early_printk.c            |  271 ---
 arch/x86_64/mm/Makefile                      |    2
 arch/x86_64/pci/Makefile                     |   19
 arch/x86_common/boot/edd.S                   |  176 ++
 arch/x86_common/kernel/bootflag.c            |   99 +
 arch/x86_common/kernel/cpu/intel_cacheinfo.c |  655 +++++++++
 arch/x86_common/kernel/cpuid.c               |  245 +++
 arch/x86_common/kernel/dmi_scan.c            |  301 ++++
 arch/x86_common/kernel/early_printk.c        |  271 +++
 arch/x86_common/kernel/i8237.c               |   67
 arch/x86_common/kernel/microcode.c           |  516 +++++++
 arch/x86_common/kernel/msr.c                 |  326 ++++
 arch/x86_common/kernel/quirks.c              |   51
 arch/x86_common/mm/hugetlbpage.c             |  289 ++++
 arch/x86_common/pci/acpi.c                   |   68
 arch/x86_common/pci/common.c                 |  261 +++
 arch/x86_common/pci/direct.c                 |  289 ++++
 arch/x86_common/pci/fixup.c                  |  467 ++++++
 arch/x86_common/pci/i386.c                   |  295 ++++
 arch/x86_common/pci/irq.c                    | 1199 +++++++++++++++++
 arch/x86_common/pci/legacy.c                 |   56
 arch/x86_common/pci/pci.h                    |   83 +
 48 files changed, 5759 insertions(+), 5734 deletions(-)

---
~Randy

#1 lore raw
Quoted 2 lines · On Wed, 8 Feb 2006 22:53:36 -0800 Randy.Dunlap wrote:

(not completed yet)
(patch applies to 2.6.16-rc2)

oh, this really is an RFC. I built x86_64 but haven't built i386 yet. and the early_printk whitespace patch conflicts with this one. :)

g/nite.

Quoted 60 lines

Patch is 331 KB and is at
http://www.xenotime.net/linux/patches/x86-common1.patch

From: Randy Dunlap <[email protected]>

Move lots of i386 & x86_64 common code into arch/x86_common/ and modify Makefiles to use it from there.

---
 arch/i386/boot/edd.S                         |  176 --
 arch/i386/boot/setup.S                       |    2
 arch/i386/kernel/Makefile                    |    8
 arch/i386/kernel/bootflag.c                  |   99 -
 arch/i386/kernel/cpu/Makefile                |    2
 arch/i386/kernel/cpu/intel_cacheinfo.c       |  655 ---------
 arch/i386/kernel/cpuid.c                     |  245 ---
 arch/i386/kernel/dmi_scan.c                  |  301 ----
 arch/i386/kernel/early_printk.c              |    2
 arch/i386/kernel/i8237.c                     |   67
 arch/i386/kernel/microcode.c                 |  516 -------
 arch/i386/kernel/msr.c                       |  326 ----
 arch/i386/kernel/quirks.c                    |   51
 arch/i386/mm/Makefile                        |    2
 arch/i386/mm/hugetlbpage.c                   |  289 ----
 arch/i386/pci/Makefile                       |   10
 arch/i386/pci/acpi.c                         |   68
 arch/i386/pci/common.c                       |  261 ---
 arch/i386/pci/direct.c                       |  289 ----
 arch/i386/pci/fixup.c                        |  467 ------
 arch/i386/pci/i386.c                         |  295 ----
 arch/i386/pci/irq.c                          | 1199 -----------------
 arch/i386/pci/legacy.c                       |   56
 arch/i386/pci/pci.h                          |   83 -
 arch/x86_64/boot/setup.S                     |    2
 arch/x86_64/kernel/Makefile                  |   16
 arch/x86_64/kernel/early_printk.c            |  271 ---
 arch/x86_64/mm/Makefile                      |    2
 arch/x86_64/pci/Makefile                     |   19
 arch/x86_common/boot/edd.S                   |  176 ++
 arch/x86_common/kernel/bootflag.c            |   99 +
 arch/x86_common/kernel/cpu/intel_cacheinfo.c |  655 +++++++++
 arch/x86_common/kernel/cpuid.c               |  245 +++
 arch/x86_common/kernel/dmi_scan.c            |  301 ++++
 arch/x86_common/kernel/early_printk.c        |  271 +++
 arch/x86_common/kernel/i8237.c               |   67
 arch/x86_common/kernel/microcode.c           |  516 +++++++
 arch/x86_common/kernel/msr.c                 |  326 ++++
 arch/x86_common/kernel/quirks.c              |   51
 arch/x86_common/mm/hugetlbpage.c             |  289 ++++
 arch/x86_common/pci/acpi.c                   |   68
 arch/x86_common/pci/common.c                 |  261 +++
 arch/x86_common/pci/direct.c                 |  289 ++++
 arch/x86_common/pci/fixup.c                  |  467 ++++++
 arch/x86_common/pci/i386.c                   |  295 ++++
 arch/x86_common/pci/irq.c                    | 1199 +++++++++++++++++
 arch/x86_common/pci/legacy.c                 |   56
 arch/x86_common/pci/pci.h                    |   83 +
 48 files changed, 5759 insertions(+), 5734 deletions(-)
Quoted 2 lines

---
~Randy

---
~Randy

#3 lore raw
In reply to Randy.Dunlap

Hi!

Quoted 10 lines

(not completed yet)
(patch applies to 2.6.16-rc2)

Patch is 331 KB and is at
http://www.xenotime.net/linux/patches/x86-common1.patch

From: Randy Dunlap <[email protected]>

Move lots of i386 & x86_64 common code into arch/x86_common/ and modify Makefiles to use it from there.

I like it... the way some files have main code in i386 and some is x86-64 is rather ugly.
Pavel

Signature · 1 line
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         
#4 lore raw
In reply to Randy.Dunlap
Quoted 10 lines · Randy.Dunlap

(not completed yet)
(patch applies to 2.6.16-rc2)

Patch is 331 KB and is at
http://www.xenotime.net/linux/patches/x86-common1.patch

From: Randy Dunlap <[email protected]>

Move lots of i386 & x86_64 common code into arch/x86_common/ and modify Makefiles to use it from there.

I know I'm quite late here, but perhaps it should be arch/common? I remember thinking ages ago the i8259 stuff could be shared between ppc32 and i386 (it was ages ago). And there's possibly other stuff like that.

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
#5 lore raw
Quoted 8 lines · Tom Rini
Quoted 6 lines · Randy.Dunlap

(not completed yet)
(patch applies to 2.6.16-rc2)

Patch is 331 KB and is at
http://www.xenotime.net/linux/patches/x86-common1.patch

Quoted 8 lines
Quoted 4 lines

From: Randy Dunlap <[email protected]>

Move lots of i386 & x86_64 common code into arch/x86_common/ and modify Makefiles to use it from there.

I know I'm quite late here, but perhaps it should be arch/common? I remember thinking ages ago the i8259 stuff could be shared between ppc32 and i386 (it was ages ago). And there's possibly other stuff like that.

Hi Tom,
Maybe, but ...
a few people like the "common" idea, but Andi has vetoed it, so I've dropped it.

Signature · 1 line
~Randy