Skip to contentSkip to conversation

libata: don't do EDD handling if ->probe_reset is used

PATCH Applied Tejun Heo 2 participants 2 messages Feb 12, 2006

Subsystems (2)
lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata: don't do EDD handling if ->probe_reset is used

EDD is never used with ->probe_reset. Don't handle EDD special case in ata_dev_identify if ->probe_reset is in use.

---

This patch should have been included in the reset patchset but was left out somehow, sorry. This patch is generated on top of "misc preps for configuration reorganization" patchset[1] I've just posted but also applies over upstream with offset.

[1] http://article.gmane.org/gmane.linux.ide/7977

 libata-core.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/libata-core.c +2 -1
Index: work1/drivers/scsi/libata-core.c
===================================================================
@@ -939,7 +939,8 @@ static void ata_dev_identify(struct ata_
 		return;
 	}
 
-	if (ap->flags & (ATA_FLAG_SRST | ATA_FLAG_SATA_RESET))
+	if (ap->ops->probe_reset ||
+	    ap->flags & (ATA_FLAG_SRST | ATA_FLAG_SATA_RESET))
 		using_edd = 0;
 	else
 		using_edd = 1;
Applied
#1 lore raw
Quoted 11 lines · Tejun Heo

EDD is never used with ->probe_reset. Don't handle EDD special case in ata_dev_identify if ->probe_reset is in use.

---

This patch should have been included in the reset patchset but was left out somehow, sorry. This patch is generated on top of "misc preps for configuration reorganization" patchset[1] I've just posted but also applies over upstream with offset.

applied