Skip to contentSkip to conversation

OMAP: Update OMAP keypad driver

DISCUSSION Komal Shah 3 participants 5 messages Feb 13, 2006 – Feb 17, 2006

lore
Share & tools
lore

Komal Shah

author
#0 lore raw

Hiroshi,

- if (cpu_is_omap24xx() && omap_has_menelaus()) {
- row_gpios[5] = 0;
- col_gpios[2] = 15;
- col_gpios[6] = 18;
- }
-

May I know, where you have moved this? As discussed earlier here, it should be in the board specific file, but I don't find it there. _or_ are you planning this in the next patch.?

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com

#1 lore raw

Hi Komal,

Quoted 10 lines · ext Komal Shah

- if (cpu_is_omap24xx() && omap_has_menelaus()) {
- row_gpios[5] = 0;
- col_gpios[2] = 15;
- col_gpios[6] = 18;
- }
-

May I know, where you have moved this? As discussed earlier here, it should be in the board specific file, but I don't find it there. _or_ are you planning this in the next patch.?

I was the one who removed that, since it breaks keypad support on all OMAP24xx boards (except H4, I presume) that have Menelaus on them. And there are quite a few of those.

Please submit a patch that moves the stuff above into board-h4.c.

Cheers,
Juha

author
#2 lore raw
Quoted 8 lines · --- Juha Yrjölä

I was the one who removed that, since it breaks keypad support on all OMAP24xx boards (except H4, I presume) that have Menelaus on them. And
there are quite a few of those.

Please submit a patch that moves the stuff above into board-h4.c.

I will submit that patch soon, having some problem in H4 setup right now.

Before that can't we convert the code below in keypad to

253 down(&kp_enable_mutex);
254 if (state != kp_enable) {
255 if (state)
256 enable_irq(INT_KEYBOARD);
257 else
258 disable_irq(INT_KEYBOARD);
259 kp_enable = state;
260 }
261 up(&kp_enable_mutex);

- Use mutex apis.
- and use platform driver data omap_kp->irq instead of INT_KEYBOARD.

Also as of now, I am not getting interrupt on H4 Menelaus keypad, looks like due to trigger flags changes...or something else.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com

#3 lore raw
Quoted 16 lines · Komal Shah
Quoted 8 lines · --- Juha Yrjölä

I was the one who removed that, since it breaks keypad support on all OMAP24xx boards (except H4, I presume) that have Menelaus on them. And
there are quite a few of those.

Please submit a patch that moves the stuff above into board-h4.c.

I will submit that patch soon, having some problem in H4 setup right now.

Before that can't we convert the code below in keypad to

Quoted 9 lines

253 down(&kp_enable_mutex);
254 if (state != kp_enable) {
255 if (state)
256 enable_irq(INT_KEYBOARD);
257 else
258 disable_irq(INT_KEYBOARD);
259 kp_enable = state;
260 }
261 up(&kp_enable_mutex);

Either you've indented incorrectly here, or you have a bug.

[snip]

Regards: David Weinehall

Signature · 3 lines
 /) David Weinehall <[email protected]> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/
author
#4 lore raw
Quoted 12 lines · --- David Weinehall
Quoted 11 lines

Before that can't we convert the code below in keypad to

253 down(&kp_enable_mutex);
254 if (state != kp_enable) {
255 if (state)
256 enable_irq(INT_KEYBOARD);
257 else
258 disable_irq(INT_KEYBOARD);
259 kp_enable = state;
260 }
261 up(&kp_enable_mutex);

Quoted 1 line

Either you've indented incorrectly here, or you have a bug.

Yes, indentation got lost while I had copy pasted code from Firefox to e-mail editor, but my point was to use mutex apis and replace INT_KEYBOARD with platform driver data instead.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com