Skip to contentSkip to conversation

Fix module refcount leak in __set_personality()

PATCH New Sergey Vlasov 1 participant 1 message Feb 15, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix module refcount leak in __set_personality()

If the change of personality does not lead to change of exec domain, __set_personality() returned without releasing the module reference acquired by lookup_exec_domain().

---

kernel/exec_domain.c +1 -0
index 867d6db..c01cead 100644
@@ -140,6 +140,7 @@ __set_personality(u_long personality)
 	ep = lookup_exec_domain(personality);
 	if (ep == current_thread_info()->exec_domain) {
 		current->personality = personality;
+		module_put(ep->module);
 		return 0;
 	}