Skip to contentSkip to conversation

i386 singlestep is borken

DISCUSSION Chuck Ebbert 2 participants 2 messages Feb 16, 2006

lore
Share & tools
lore
#0 lore raw

Playing around with singlestep on i386, I found this:

1. User sets TF and starts to singlestep through code, handling SIGTRAPS as they occur.

2. Makes vsyscall; debug trap occurs in kernel mode and TF is cleared. TIF_SINGLESTEP gets set so kernel will remember to re-enable TF on return to user. But when user eflags is saved on the stack, TF has already been cleared.

3. When user gets control back, TF is not re-enabled.

4. Even after user clears TF, TIF_SINGLESTEP remains set for that thread.

None of this happens when using int80 because the flag is cleared and re-enabled by the interrupt handler. TIF_SINGLESTEP never gets set and doesn't need to be.

Signature · 2 lines
Chuck
"Equations are the Devil's sentences."  --Stephen Colbert
#1 lore raw
Quoted 5 lines · Chuck Ebbert

2. Makes vsyscall; debug trap occurs in kernel mode and TF is cleared. TIF_SINGLESTEP gets set so kernel will remember to re-enable TF on return to user. But when user eflags is saved on the stack, TF has already been cleared.

This is exactly correct.

TF should be re-enabled by the "is there work to be done at system call return time?" logic, which should mean that we go through do_notify_resume() (which will set TF_MASK) and return with an "iret".

We can't return with a sysexit in the TF case, and setting TF on the stack is thus useless.

Quoted 1 line

3. When user gets control back, TF is not re-enabled.

Sounds like something is broken, but I don't see what.

I did check single-step over sysenter at some point (a long time ago), so this has worked.

Linus