Skip to contentSkip to conversation

powerpc: Fix accidentally-working typo in __pud_free_tlb

PATCH David Gibson 1 participant 1 message Feb 17, 2006

lore
Share & tools
lore
#0 lore raw

Andrew, Paulus, please apply.

One of the parameters to the __pud_free_tlb() macro for powerpc is incorrect (see patch) . We get away with it by accident, because the one place the macro is called, the second parameter is a variable named "pud".

Nonetheless, this should be fixed for 2.6.16.

include/asm-powerpc/pgalloc.h +1 -1
Index: working-2.6/include/asm-powerpc/pgalloc.h
===================================================================
@@ -146,7 +146,7 @@ extern void pgtable_free_tlb(struct mmu_
 	pgtable_free_tlb(tlb, pgtable_free_cache(pmd, \
 		PMD_CACHE_NUM, PMD_TABLE_SIZE-1))
 #ifndef CONFIG_PPC_64K_PAGES
-#define __pud_free_tlb(tlb, pmd)	\
+#define __pud_free_tlb(tlb, pud)	\
 	pgtable_free_tlb(tlb, pgtable_free_cache(pud, \
 		PUD_CACHE_NUM, PUD_TABLE_SIZE-1))
 #endif /* CONFIG_PPC_64K_PAGES */
Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson