sym53c8xx_2: Add bios_param to sym_glue.c
PATCH 1/1 sym53c8xx_2: Add bios_param to sym_glue.c
This patch adds the scsi common function bios_param to the sym53c8xx driver. For simplicity i just copied the code from the sym53c416 driver.
Patch applies to 2.6.16-rc3
drivers/scsi/sym53c8xx_2/sym_glue.c 2006-02-17 14:50:55.000000000 +0100 renamed from drivers/scsi/sym53c8xx_2/sym_glue.c.orig 2006-02-17 14:49:12.000000000 +0100 +23 -0
@@ -1963,6 +1963,28 @@ static int sym_detach(struct sym_hcb *np } /* + * Bios param for sd. + * Copied from sym53c416 driver + */ +static int sym53c8xx_bios_param(struct scsi_device *sdev, + struct block_device *dev, + sector_t capacity, int *ip) +{ + int size; + + size = capacity; + ip[0] = 64; /* heads */ + ip[1] = 32; /* sectors */ + if((ip[2] = size >> 11) > 1024) /* cylinders, test for big disk */ + { + ip[0] = 255; /* heads */ + ip[1] = 63; /* sectors */ + ip[2] = size / (255 * 63); /* cylinders */ + } + return 0; +} + +/* * Driver host template. */ static struct scsi_host_template sym2_template = {
@@ -1977,6 +1999,7 @@ static struct scsi_host_template sym2_te .eh_device_reset_handler = sym53c8xx_eh_device_reset_handler, .eh_bus_reset_handler = sym53c8xx_eh_bus_reset_handler, .eh_host_reset_handler = sym53c8xx_eh_host_reset_handler, + .bios_param = sym53c8xx_bios_param, .this_id = 7, .use_clustering = DISABLE_CLUSTERING, #ifdef SYM_LINUX_PROC_INFO_SUPPORT
Quoted 2 lines · Seewer Philippe
This patch adds the scsi common function
bios_paramto the sym53c8xx driver. For simplicity i just copied the code from the sym53c416 driver.
If the driver doesn't define bios_param, the scsi core calls scsicam_bios_param, which seems to do everything this patch does, and more.
A quick survey suggests that most drivers should have their bios_param methods deleted. Was there a particular problem you found with the default scsicam_bios_param implementation?
Quoted 6 lines · Matthew Wilcox
Quoted 2 lines · Seewer Philippe
This patch adds the scsi common function
bios_paramto the sym53c8xx driver. For simplicity i just copied the code from the sym53c416 driver.
Quoted 7 lines
If the driver doesn't define
bios_param, the scsi core callsscsicam_bios_param, which seems to do everything this patch does, and more.A quick survey suggests that most drivers should have their
bios_parammethods deleted. Was there a particular problem you found with the defaultscsicam_bios_paramimplementation?
Yes. Using scsicam_bios_parm and other defaults result in a geometry of 64 heads and 32 sectors even for big disks, which is not what the pc bios "gets" from the controller. That is more along the lines of 255/63.
Returning a geometry of x/255/63 seems to be the default for bigger disks withing scsi drivers, so i just copied the code...