Small time UART configuration fix for AU1100 processor
PATCH 1/1 Small time UART configuration fix for AU1100 processor
Hi,
The AU1100 processor does not have an internal UART2. Only UART0, UART1 and UART3 exist. This patch removes the non existing UART2 and replaces it with a descriptive comment.
Signature · 4 lines
$ cat ~/.signature Freddy Spierenburg <[email protected]> http://snarl.nl/~freddy/ GnuPG: 0x7941D1E1=C948 5851 26D2 FA5C 39F1 E588 6F17 FD5D 7941 D1E1 $ # Please read http://www.ietf.org/rfc/rfc2015.txt before complain!
drivers/serial/8250_au1x00.c +1 -1
@@ -51,7 +51,7 @@#elif defined(CONFIG_SOC_AU1100 ) PORT(UART0_ADDR, AU1100_UART0_INT), PORT(UART1_ADDR, AU1100_UART1_INT), - PORT(UART2_ADDR, AU1100_UART2_INT), + /* The internal UART2 does not exist on the AU1100 processor. */ PORT(UART3_ADDR, AU1100_UART3_INT), #elif defined(CONFIG_SOC_AU1550) PORT(UART0_ADDR, AU1550_UART0_INT),
Quoted 3 lines
The AU1100 processor does not have an internal UART2. Only UART0, UART1 and UART3 exist. This patch removes the non existing UART2 and replaces it with a descriptive comment.
Thanks. I think that Ralf already told you to send it to Russell King, but I'll toss it in my tree as well, in case he doesn't get it.
The comment probably isn't required, though - just remove it.
I know this is a stupid question for an AMD employee to ask, but since I've only been associated with the AU1200, and to a limited extent the AU1550, do *ANY* of our boards have an UART2 on them?
Jordan
Hello.
Quoted 3 lines · Jordan Crouse
I know this is a stupid question for an AMD employee to ask, but since I've only been associated with the AU1200, and to a limited extent the AU1550, do *ANY* of our boards have an UART2 on them?
Looks like only Au1000 SOC has all 4 UARTs. The other SOCs have UART2
missing...
Quoted 1 line
Jordan
WBR, Sergei
Hi Jordan,
Quoted 2 lines · Jordan Crouse
I think that Ralf already told you to send it to Russell King, but I'll toss it in my tree as well, in case he doesn't get it.
I have already send it to Russell yes, so...
Quoted 1 line
The comment probably isn't required, though - just remove it.
...no chance to remove the comment anymore. Well, it actually does not hurt that much (IMHO) and saves newbies like me some searching. :-)
Quoted 3 lines
I know this is a stupid question for an AMD employee to ask, but since I've only been associated with the AU1200, and to a limited extent the AU1550, do *ANY* of our boards have an UART2 on them?
Unfortunately I have no idea. I'm fairly new (two weeks actually) to this architecture and the AU1100 is the only AMD board I have access to. Sorry.
Signature · 4 lines
$ cat ~/.signature Freddy Spierenburg <[email protected]> http://snarl.nl/~freddy/ GnuPG: 0x7941D1E1=C948 5851 26D2 FA5C 39F1 E588 6F17 FD5D 7941 D1E1 $ # Please read http://www.ietf.org/rfc/rfc2015.txt before complain!