Skip to contentSkip to conversation

don't bother users with unimportant messages.

PATCH Dave Jones 5 participants 11 messages Feb 19, 2006 Driver core

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

When users see these printed to the console, they think something is wrong. As it's just informational and something that only developers care about, lower the printk level.

drivers/base/driver.c renamed from drivers/base/driver.c~ +1 -1
@@ -174,7 +174,7 @@ int driver_register(struct device_driver
 	if ((drv->bus->probe && drv->probe) ||
 	    (drv->bus->remove && drv->remove) ||
 	    (drv->bus->shutdown && drv->shutdown)) {
-		printk(KERN_WARNING "Driver '%s' needs updating - please use bus_type methods\n", drv->name);
+		printk(KERN_DEBUG "Driver '%s' needs updating - please use bus_type methods\n", drv->name);
 	}
 	klist_init(&drv->klist_devices, klist_devices_get, klist_devices_put);
 	init_completion(&drv->unloaded);
#1 lore raw

From: Dave Jones <[email protected]>
Date: Sat, 18 Feb 2006 20:09:10 -0500

Quoted 5 lines

When users see these printed to the console, they think something is wrong. As it's just informational and something that only developers care about, lower the printk level.

I'm partly against such changes, especially lately...

I've been burned so many times over the past few days by things like installers, klogd, and whatever else changing the loglevel on me so that the one console message I needed to see right before the machine hung doesn't get printed out.

#2 lore raw
In reply to Dave Jones
Quoted 3 lines · Dave Jones

When users see these printed to the console, they think something is wrong. As it's just informational and something that only developers care about, lower the printk level.

If you're getting complaints about this, wouldn't it be better to forward them here so that they can be fixed up?

The thing about this particular message is that if you see it, the driver will _not_ work properly, so it's actually more than a "debugging" message. It's telling you why driver FOO doesn't work.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
author
#3 lore raw
Quoted 7 lines · Russell King
Quoted 3 lines · Dave Jones

When users see these printed to the console, they think something is wrong. As it's just informational and something that only developers care about, lower the printk level.

If you're getting complaints about this, wouldn't it be better to forward them here so that they can be fixed up?

w83627hf, and probably other drivers from drivers/hwmon/

Quoted 3 lines

The thing about this particular message is that if you see it, the driver will _not_ work properly, so it's actually more than a "debugging" message. It's telling you why driver FOO doesn't work.

I'm pretty certain this driver _was_ working fine before this change.

Dave

#4 lore raw
Quoted 10 lines · Dave Jones
Quoted 7 lines · Russell King
Quoted 3 lines · Dave Jones

When users see these printed to the console, they think something is wrong. As it's just informational and something that only developers care about, lower the printk level.

If you're getting complaints about this, wouldn't it be better to forward them here so that they can be fixed up?

w83627hf, and probably other drivers from drivers/hwmon/

I don't see it - w83627hf registers w83627hf_driver via i2c_isa_add_driver, which does not have any probe, remove or shutdown methods. Moreover, i2c_isa_add_driver doesn't set any of these methods. So how can:

        if ((drv->bus->probe && drv->probe) ||
            (drv->bus->remove && drv->remove) ||
            (drv->bus->shutdown && drv->shutdown)) {

be true? Local distro modifications maybe?

Quoted 6 lines
Quoted 4 lines

The thing about this particular message is that if you see it, the driver will _not_ work properly, so it's actually more than a "debugging" message. It's telling you why driver FOO doesn't work.

I'm pretty certain this driver _was_ working fine before this change.

If driver->bus->{probe,remove,shutdown} are set, the driver model will _not_ call driver->{probe,remove,shutdown} itself. Hence, if both contain pointers then it's highly likely the driver will not work. Not reporting these instances will lead to users complaining "my driver doesn't work" and then a headache for someone to work out why - since nothing obvious will have changed.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
author
#5 lore raw
Quoted 16 lines · Russell King
Quoted 10 lines · Dave Jones
Quoted 7 lines · Russell King
Quoted 3 lines · Dave Jones

When users see these printed to the console, they think something is wrong. As it's just informational and something that only developers care about, lower the printk level.

If you're getting complaints about this, wouldn't it be better to forward them here so that they can be fixed up?

w83627hf, and probably other drivers from drivers/hwmon/

I don't see it - w83627hf registers w83627hf_driver via i2c_isa_add_driver, which does not have any probe, remove or shutdown methods. Moreover, i2c_isa_add_driver doesn't set any of these methods. So how can:

Quoted 5 lines
        if ((drv->bus->probe && drv->probe) ||
            (drv->bus->remove && drv->remove) ||
            (drv->bus->shutdown && drv->shutdown)) {

be true?

Beats me. I'll put some printk's in there, and see what falls out.

Quoted 1 line

Local distro modifications maybe?

Nope. drivers/hwmon & drivers/i2c is untouched.

Dave

#6 lore raw
In reply to Dave Jones
Quoted 10 lines · Dave Jones
Quoted 7 lines · Russell King
Quoted 3 lines · Dave Jones

When users see these printed to the console, they think something is wrong. As it's just informational and something that only developers care about, lower the printk level.

If you're getting complaints about this, wouldn't it be better to forward them here so that they can be fixed up?

w83627hf, and probably other drivers from drivers/hwmon/

With 2.6.16-rc4? I thought I just sent a patch in for -rc3 to fix this.

thanks,

greg k-h

author
#7 lore raw
Quoted 6 lines · Greg Kroah-Hartman
Quoted 4 lines
Quoted 2 lines

If you're getting complaints about this, wouldn't it be better to forward them here so that they can be fixed up?

w83627hf, and probably other drivers from drivers/hwmon/

With 2.6.16-rc4? I thought I just sent a patch in for -rc3 to fix this.

Yep, user was running an older kernel.
Much ado about nothing..

Thanks,

Dave

#8 lore raw
Quoted 11 lines · Dave Jones
Quoted 6 lines · Greg Kroah-Hartman
Quoted 4 lines
Quoted 2 lines

If you're getting complaints about this, wouldn't it be better to forward them here so that they can be fixed up?

w83627hf, and probably other drivers from drivers/hwmon/

With 2.6.16-rc4? I thought I just sent a patch in for -rc3 to fix this.

Yep, user was running an older kernel.
Much ado about nothing..

Great, thanks for checking up on this.

greg k-h

#9 lore raw
In reply to Greg KH
Quoted 7 lines · Greg KH
Quoted 6 lines · Dave Jones
Quoted 5 lines · Russell King
Quoted 3 lines · Dave Jones

When users see these printed to the console, they think something is wrong. As it's just informational and something that only developers care about, lower the printk level.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

If you're getting complaints about this, wouldn't it be better to forward them here so that they can be fixed up?

w83627hf, and probably other drivers from drivers/hwmon/

With 2.6.16-rc4? I thought I just sent a patch in for -rc3 to fix this.

It must be in rc4 Greg, I didn't see that error on the rc4 bootup.

Quoted 8 lines

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 7 lines
Cheers, Gene
People having trouble with vz bouncing email to me should add the word
'online' between the 'verizon', and the dot which bypasses vz's
stupid bounce rules.  I do use spamassassin too. :-)
Yahoo.com and AOL/TW attorneys please note, additions to the above
message by Gene Heskett are:
Copyright 2006 by Maurice Eugene Heskett, all rights reserved.
#10 lore raw
In reply to Dave Jones
Quoted 11 lines · Dave Jones
Quoted 7 lines · Russell King
Quoted 3 lines · Dave Jones

When users see these printed to the console, they think something is wrong. As it's just informational and something that only developers care about, lower the printk level.

If you're getting complaints about this, wouldn't it be better to forward them here so that they can be fixed up?

w83627hf, and probably other drivers from drivers/hwmon/

Quoted 7 lines
Quoted 3 lines

The thing about this particular message is that if you see it, the driver will _not_ work properly, so it's actually more than a "debugging" message. It's telling you why driver FOO doesn't work.

I'm pretty certain this driver _was_ working fine before this change.

Dave

I got an advisory about w83627hf in my logs, but not from the rc4 reboot. The previous ones were:

Feb 13 00:31:18 coyote kernel: Driver 'w83627hf' needs updating - please 
use bus_type methods
Feb 13 00:36:20 coyote kernel: Driver 'w83627hf' needs updating - please 

use bus_type methods

Two quick reboots there, the first one would have been rc2, I forgot to update grub.conf :(

which would have been booted to rc2 and 3, not rc4. I believe they started at rc1 but I won't swear to that. gkrellm and sensors are both working albeit sensors is saying C for the diode in the cpu when it should be F

gkrellm-2.28 is displaying it correctly though.

So apparently something has been updated with rc4?

Signature · 7 lines
Cheers, Gene
People having trouble with vz bouncing email to me should add the word
'online' between the 'verizon', and the dot which bypasses vz's
stupid bounce rules.  I do use spamassassin too. :-)
Yahoo.com and AOL/TW attorneys please note, additions to the above
message by Gene Heskett are:
Copyright 2006 by Maurice Eugene Heskett, all rights reserved.