Skip to contentSkip to conversation

workaround a cscope bug (make cscope segfaults)

PATCH In review Mattia Dongili 2 participants 2 messages Feb 19, 2006 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 workaround a cscope bug (make cscope segfaults)

Workaround a cscope bug where a trailing ':' in VPATH makes it segfault and let it build the cross-reference succesfully.

VPATH=/home/mattia/devel/kernel/git/linux-2.6: cscope -b
[1] 17555 segmentation fault VPATH=/home/mattia/devel/kernel/git/linux-2.6: cscope -b

---

'make cscope' segfaults with current kbuild.git (I'm using -rc3-mm1 actually and the same problem appears in some previous versions too).
I'm running Debian's cscope-15.5+cvs20050816-1 (cscope --version says 16.0a).

I think it would be nice to have this workaround as cscope CVS doesn't show much activity and its latest release dates somewhen in 2003.

As shown above, to reproduce the segfault here I just need to run VPATH=/home/mattia/devel/kernel/git/linux-2.6: cscope -b in the kernel source tree with the previously generated cscope.files, the trailing ':' is what makes cscope die.

 Makefile |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

77d1a8a386df409709ad0b4f48a8b09ce08d990d

Makefile +4 -0
index 111a699..e0f9108 100644
@@ -138,7 +138,11 @@ objtree		:= $(CURDIR)
 src		:= $(srctree)
 obj		:= $(objtree)
 
+ifeq ($(KBUILD_EXTMOD),)
+VPATH		:= $(srctree)
+else
 VPATH		:= $(srctree):$(KBUILD_EXTMOD)
+endif
 
 export srctree objtree VPATH TOPDIR
 
Signature · 5 lines
1.2.1-dirty

-- 
mattia
:wq!
#1 lore raw
Quoted 8 lines · Mattia Dongili

Workaround a cscope bug where a trailing ':' in VPATH makes it segfault and let it build the cross-reference succesfully.

VPATH=/home/mattia/devel/kernel/git/linux-2.6: cscope -b
[1] 17555 segmentation fault VPATH=/home/mattia/devel/kernel/git/linux-2.6: cscope -b

Hi Mattia.
I have added the following patch to my tree.
Thanks for the report.

Sam

Makefile +1 -1
index a55a1e4..7a95f4f 100644
@@ -137,7 +137,7 @@ objtree		:= $(CURDIR)
 src		:= $(srctree)
 obj		:= $(objtree)
 
-VPATH		:= $(srctree):$(KBUILD_EXTMOD)
+VPATH		:= $(srctree)$(if $(KBUILD_EXTMOD),:$(KBUILD_EXTMOD))
 
 export srctree objtree VPATH TOPDIR