Skip to contentSkip to conversation

Add target 'cscope' to Makefile

PATCH New Horst Kronstorfer 3 participants 5 messages Feb 19, 2006 – Oct 11, 2006 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add target 'cscope' to Makefile

hi!

the following patch adds target 'cscope' to the main makefile. it also puts the list of directories with source files and the arguments to `find' into make variables.

Makefile +14 -11
index 9305cab..80e3677 100644
@@ -135,6 +135,14 @@ SUBDIRS	= tools \
 	  post/cpu
 .PHONY : $(SUBDIRS)
 
+# Directories with files for tag generation
+TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
+ lib_$(ARCH) fs/cramfs fs/fat fs/fdos fs/jffs2 net disk rtc dtt drivers\
+ drivers/sk98lin common
+
+# Arguments to `find' when generating a list of files for tag generation
+TAGFINDARGS := \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)
+
 #########################################################################
 #########################################################################
 
@@ -179,19 +187,14 @@ gdbtools:
 depend dep:
 		@for dir in $(SUBDIRS) ; do $(MAKE) -C $$dir .depend ; done
 
+cscope:
+		find $(TAGDIRS) $(TAGFINDARGS) >cscope.files; cscope -b -q -k
+
 tags:
-		ctags -w `find $(SUBDIRS) include \
-				lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
-				fs/cramfs fs/fat fs/fdos fs/jffs2 \
-				net disk rtc dtt drivers drivers/sk98lin common \
-			\( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
+		ctags -w `find $(TAGDIRS) $(TAGFINDARGS)`
 
 etags:
-		etags -a `find $(SUBDIRS) include \
-				lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
-				fs/cramfs fs/fat fs/fdos fs/jffs2 \
-				net disk rtc dtt drivers drivers/sk98lin common \
-			\( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
+		etags -a `find $(TAGDIRS) $(TAGFINDARGS)`
 
 System.map:	u-boot
 		@$(NM) $< | \
@@ -1838,7 +1841,7 @@ clobber:	clean
 		-o -name '*.srec' -o -name '*.bin' -o -name u-boot.img \) \
 		-print0 \
 		| xargs -0 rm -f
-	rm -f $(OBJS) *.bak tags TAGS
+	rm -f $(OBJS) *.bak tags TAGS cscope.*
 	rm -fr *.*~
 	rm -f u-boot u-boot.map u-boot.hex $(ALL)
 	rm -f tools/crc32.c tools/environment.c tools/env/crc32.c

-h

#1 lore raw

PATCH 1/1 Add target 'cscope' to Makefile

Quoted 4 lines · In message <20060219150640.GA3310@aquarius> you wrote:

the following patch adds target 'cscope' to the main makefile. it also puts the list of directories with source files and the arguments to `find' into make variables.

Rejected. Please resubmit after including a CHANGELOG entry that describes what you do, and why. Don't assume that everybody knows what a "target 'cscope'" might be good for.

Best regards,

Wolfgang Denk

Signature · 5 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
About the use of language: it is impossible to sharpen a pencil  with
a  blunt  ax.  It is equally vain to try to do it with ten blunt axes
instead.                                           -- Edsger Dijkstra
#2 lore raw

PATCH 1/1 Add target 'cscope' to Makefile

In reply to Horst Kronstorfer
Quoted 4 lines · In message <20060219150640.GA3310@aquarius> you wrote:

the following patch adds target 'cscope' to the main makefile. it also puts the list of directories with source files and the arguments to `find' into make variables.

On second look, I think this patch needs some more work:

Makefile SUBDIRS = tools \ · line 141

Quoted 4 lines
Makefile +4 -0
+# Directories with files for tag generation
+TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
+ lib_$(ARCH) fs/cramfs fs/fat fs/fdos fs/jffs2 net disk rtc dtt drivers\
+ drivers/sk98lin common

This doesn't look complete to me - for example, how about post/ ?

Makefile SUBDIRS = tools \ · line 144

Quoted 2 lines
Makefile +2 -0
+# Arguments to `find' when generating a list of files for tag generation
+TAGFINDARGS := \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)

You should probably also exclude .git directories here, just in case.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Those who will be able to conquer software will be able  to  conquer
the world."                 - Tadahiro Sekimoto, president, NEC Corp.
#3 lore raw

PATCH 1/1 Add target 'cscope' to Makefile

Quoted 6 lines · Wolfgang Denk
Quoted 4 lines · In message <20060219150640.GA3310@aquarius> you wrote:

the following patch adds target 'cscope' to the main makefile. it also puts the list of directories with source files and the arguments to `find' into make variables.

Quoted 9 lines

On second look, I think this patch needs some more work:

Review

Quoted 4 lines
(quoted diff) +4 -0
+# Directories with files for tag generation
+TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
+ lib_$(ARCH) fs/cramfs fs/fat fs/fdos fs/jffs2 net disk rtc dtt drivers\
+ drivers/sk98lin common

This doesn't look complete to me - for example, how about post/ ?

post is included in $(SUBDIRS), but you're right, some 'fs' subdirs were missing. i should have examined it when i copied the directory list from the 'tags'/'etags' target.

Quoted 5 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+# Arguments to `find' when generating a list of files for tag generation
+TAGFINDARGS := \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)

You should probably also exclude .git directories here, just in case.

oke. i also excluded .svn (subversion)

-h

---

CHANGELOG
* Added target 'cscope' to the main makefile. cscope (like ctags/etags) is a tool for browsing source code. For further information go to the cscope website at http://cscope.sourceforge.net/. An alternative to cscope named freescope is available at http://freescope.sourceforge.net/.
Patch by Horst Kronstorfer, 20 Feb 2006

Makefile +14 -11
index 9305cab..6ccbe0c 100644
@@ -135,6 +135,14 @@ SUBDIRS	= tools \
 	  post/cpu
 .PHONY : $(SUBDIRS)
 
+# Directories with files for tag generation
+TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
+ lib_$(ARCH) fs net disk rtc dtt drivers common
+
+# Arguments to `find' when generating a list of files for tag generation
+TAGFINDARGS := \( -name CVS -prune \) -o \( -name .git -prune \) -o\
+ \( -name .svn -prune \) -o \( -name '*.[ch]' -print \)
+
 #########################################################################
 #########################################################################
 
@@ -179,19 +187,14 @@ gdbtools:
 depend dep:
 		@for dir in $(SUBDIRS) ; do $(MAKE) -C $$dir .depend ; done
 
+cscope:
+		find $(TAGDIRS) $(TAGFINDARGS) >cscope.files; cscope -b -q -k
+
 tags:
-		ctags -w `find $(SUBDIRS) include \
-				lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
-				fs/cramfs fs/fat fs/fdos fs/jffs2 \
-				net disk rtc dtt drivers drivers/sk98lin common \
-			\( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
+		ctags -w `find $(TAGDIRS) $(TAGFINDARGS)`
 
 etags:
-		etags -a `find $(SUBDIRS) include \
-				lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
-				fs/cramfs fs/fat fs/fdos fs/jffs2 \
-				net disk rtc dtt drivers drivers/sk98lin common \
-			\( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
+		etags -a `find $(TAGDIRS) $(TAGFINDARGS)`
 
 System.map:	u-boot
 		@$(NM) $< | \
@@ -1838,7 +1841,7 @@ clobber:	clean
 		-o -name '*.srec' -o -name '*.bin' -o -name u-boot.img \) \
 		-print0 \
 		| xargs -0 rm -f
-	rm -f $(OBJS) *.bak tags TAGS
+	rm -f $(OBJS) *.bak tags TAGS cscope.*
 	rm -fr *.*~
 	rm -f u-boot u-boot.map u-boot.hex $(ALL)
 	rm -f tools/crc32.c tools/environment.c tools/env/crc32.c
#4 lore raw

PATCH 1/1 Add target 'cscope' to Makefile

Wolfgang, what's the status of this patch? Does it still need work to go into mainline?

Thanks,
g.

Quoted 108 lines · Horst Kronstorfer
Quoted 6 lines · Wolfgang Denk
Quoted 4 lines · In message <20060219150640.GA3310@aquarius> you wrote:

the following patch adds target 'cscope' to the main makefile. it also puts the list of directories with source files and the arguments to `find' into make variables.

Quoted 9 lines

On second look, I think this patch needs some more work:

Makefile SUBDIRS = tools \

Quoted 4 lines
Makefile +4 -0
+# Directories with files for tag generation
+TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
+ lib_$(ARCH) fs/cramfs fs/fat fs/fdos fs/jffs2 net disk rtc dtt drivers\
+ drivers/sk98lin common

This doesn't look complete to me - for example, how about post/ ?

post is included in $(SUBDIRS), but you're right, some 'fs' subdirs were missing. i should have examined it when i copied the directory list from the 'tags'/'etags' target.

Quoted 5 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+# Arguments to `find' when generating a list of files for tag generation
+TAGFINDARGS := \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)

You should probably also exclude .git directories here, just in case.

oke. i also excluded .svn (subversion)

-h

---

CHANGELOG
* Added target 'cscope' to the main makefile. cscope (like ctags/etags) is a tool for browsing source code. For further information go to the cscope website at http://cscope.sourceforge.net/. An alternative to cscope named freescope is available at http://freescope.sourceforge.net/.
Patch by Horst Kronstorfer, 20 Feb 2006

Makefile +14 -12
index 9305cab..6ccbe0c 100644
@@ -135,6 +135,14 @@ SUBDIRS    = tools \
          post/cpu
 .PHONY : $(SUBDIRS)
 
+# Directories with files for tag generation
+TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
+ lib_$(ARCH) fs net disk rtc dtt drivers common
+
+# Arguments to `find' when generating a list of files for tag generation
+TAGFINDARGS := \( -name CVS -prune \) -o \( -name .git -prune \) -o\
+ \( -name .svn -prune \) -o \( -name '*.[ch]' -print \)
+
 #########################################################################
 #########################################################################
 
@@ -179,19 +187,14 @@ gdbtools:
 depend dep:
                @for dir in $(SUBDIRS) ; do $(MAKE) -C $$dir .depend ; done
 
+cscope:
+               find $(TAGDIRS) $(TAGFINDARGS) >cscope.files; cscope -b -q -k
+
 tags:
-               ctags -w `find $(SUBDIRS) include \
-                               lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
-                               fs/cramfs fs/fat fs/fdos fs/jffs2 \
-                               net disk rtc dtt drivers drivers/sk98lin common \
-                       \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
+               ctags -w `find $(TAGDIRS) $(TAGFINDARGS)`
 
 etags:
-               etags -a `find $(SUBDIRS) include \
-                               lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
-                               fs/cramfs fs/fat fs/fdos fs/jffs2 \
-                               net disk rtc dtt drivers drivers/sk98lin common \
-                       \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
+               etags -a `find $(TAGDIRS) $(TAGFINDARGS)`
 
 System.map:    u-boot
                @$(NM) $< | \
@@ -1838,7 +1841,7 @@ clobber:  clean
                -o -name '*.srec' -o -name '*.bin' -o -name u-boot.img \) \
                -print0 \
                | xargs -0 rm -f
-       rm -f $(OBJS) *.bak tags TAGS
+       rm -f $(OBJS) *.bak tags TAGS cscope.*
        rm -fr *.*~
        rm -f u-boot u-boot.map u-boot.hex $(ALL)
        rm -f tools/crc32.c tools/environment.c tools/env/crc32.c
 
 
-------------------------------------------------------

This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Signature · 4 lines
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195