Fix undefined symbols for nommu architecture
PATCH 1/1 Fix undefined symbols for nommu architecture
Hi,
This is a patch to add or export some undefined symbols in nommu
architectures (mm/nommu.c). Based on latest mm-tree. Following symbols are added: vmap, vunmap, randomize_va_space.
linux-2.6/mm/nommu.c +3 -0
@@ -57,7 +57,10 @@EXPORT_SYMBOL (vfree);EXPORT_SYMBOL (vmalloc_to_page);EXPORT_SYMBOL (vmalloc_32); +EXPORT_SYMBOL (vmap); +EXPORT_SYMBOL (vunmap); +int randomize_va_space =0 ;/* * Handle all mappings that got truncated by a "truncate()" * system call.
--
Best regards,
Luke Yang
[email protected]; [email protected]
Quoted 14 lines · Luke Yang
Hi,
This is a patch to add or export some undefined symbols in nommu
architectures (mm/nommu.c). Based on latest mm-tree. Following symbols are added: vmap, vunmap,randomize_va_space.Signed-off-by Luke Yang <[email protected]>Index:
git/linux-2.6/mm/nommu.c
===================================================================
linux-2.6/mm/nommu.c line 61
Quoted 5 lines
linux-2.6/mm/nommu.c +2
-0@@ -57,7 +57,10 @@EXPORT_SYMBOL (vfree);EXPORT_SYMBOL (vmalloc_to_page);EXPORT_SYMBOL (vmalloc_32); +EXPORT_SYMBOL (vmap); +EXPORT_SYMBOL (vunmap);
OK.
linux-2.6/mm/nommu.c line 63
Quoted 1 line
linux-2.6/mm/nommu.c +1
-0+int randomize_va_space =0 ;
Not so sure about this one. Does randomize_va_space actually make sense in a nommu environment? I guess we could load relocatable binaries into a randomised place, but I'm not sure that this is implemented?
If no, then it would make more sense to do
#define randomize_va_space 0
for nommu, so the relevant code gets thrown away by the compiler.
Quoted 23 lines · Andrew Morton
Quoted 14 lines · Luke Yang
Hi,
This is a patch to add or export some undefined symbols in nommu
architectures (mm/nommu.c). Based on latest mm-tree. Following symbols are added: vmap, vunmap,randomize_va_space.Signed-off-by Luke Yang <[email protected]>Index:
git/linux-2.6/mm/nommu.c
===================================================================linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800 line 61
Quoted 5 lines
linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800 renamed from linux-2.6/mm/nommu.c 2006-02-17 17:40:34.000000000 +0800 +2
-0@@ -57,7 +57,10 @@ EXPORT_SYMBOL(vfree); EXPORT_SYMBOL(vmalloc_to_page); EXPORT_SYMBOL(vmalloc_32); +EXPORT_SYMBOL(vmap); +EXPORT_SYMBOL(vunmap);OK.
Quoted 5 lines
linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800 line 62
Quoted 1 line
linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800 renamed from linux-2.6/mm/nommu.c 2006-02-17 17:40:34.000000000 +0800 +1
-0+int randomize_va_space = 0;Not so sure about this one. Does
randomize_va_spaceactually make sense in a nommu environment? I guess we could load relocatable binaries into a randomised place, but I'm not sure that this is implemented?
No, it doesn't make sense now. NOMMU architectures don't really use
it. I put it here just to avoid "undefined symbol" error.
Quoted 4 lines
If no, then it would make more sense to do
#define randomize_va_space 0
Yes, this is much better. Do I need to resend a new patch?
Quoted 3 lines
for nommu, so the relevant code gets thrown away by the compiler.
--
Best regards,
Luke Yang
[email protected]; [email protected]
Quoted 11 lines · Luke Yang
Quoted 4 lines
Not so sure about this one. Does
randomize_va_spaceactually make sense in a nommu environment? I guess we could load relocatable binaries into a randomised place, but I'm not sure that this is implemented?No, it doesn't make sense now. NOMMU architectures don't really use
it. I put it here just to avoid "undefined symbol" error.Quoted 4 lines
If no, then it would make more sense to do
#define randomize_va_space 0Yes, this is much better. Do I need to resend a new patch?
Yes please - I'm not set up to compile any nommu architectures.