Skip to contentSkip to conversation

altix: export sn_pcidev_info_get

PATCH In review Mark Maule 6 participants 12 messages Feb 14, 2006 – Mar 1, 2006

lore
Share & tools
lore

Mark Maule

author
#0 lore raw

PATCH 1/1 altix: export sn_pcidev_info_get

Export sn_pcidev_info_get.

Signed-off-by Mark Maule <[email protected]>

Index: suse-patches/arch/ia64/sn/kernel/io_init.c
=================================--- suse-patches.orig/arch/ia64/sn/kernel/io_init.c 2006-02-14 09:54:34.000000000 -0600
+++ suse-patches/arch/ia64/sn/kernel/io_init.c 2006-02-14 09:57:40.095264008 -0600
@@ -734,3 +734,4 @@
EXPORT_SYMBOL(sn_pci_controller_fixup);
EXPORT_SYMBOL(sn_bus_store_sysdata);
EXPORT_SYMBOL(sn_bus_free_sysdata);
+EXPORT_SYMBOL(sn_pcidev_info_get);

#1 lore raw
Quoted 1 line · Mark Maule

Export sn_pcidev_info_get.

Tony or Andrew please back this out again. The only reason SGI wants this is to support their illegal graphics driver, and no core code uses it.

And Mark, please stop submitting such patches.

#2 lore raw
Quoted 5 lines · Christoph Hellwig
Quoted 1 line · Mark Maule

Export sn_pcidev_info_get.

Tony or Andrew please back this out again.

Please send a patch.

#3 lore raw
Quoted 8 lines · Andrew Morton
Quoted 5 lines · Christoph Hellwig
Quoted 1 line · Mark Maule

Export sn_pcidev_info_get.

Tony or Andrew please back this out again.

Please send a patch.

arch/ia64/sn/kernel/io_init.c +0 -1
@@ -716,4 +716,3 @@ EXPORT_SYMBOL(sn_pci_unfixup_slot);
 EXPORT_SYMBOL(sn_pci_controller_fixup);
 EXPORT_SYMBOL(sn_bus_store_sysdata);
 EXPORT_SYMBOL(sn_bus_free_sysdata);
-EXPORT_SYMBOL(sn_pcidev_info_get);
#4 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 8 lines · Andrew Morton
Quoted 5 lines · Christoph Hellwig
Quoted 1 line · Mark Maule

Export sn_pcidev_info_get.

Tony or Andrew please back this out again.

Please send a patch.

ping?

arch/ia64/sn/kernel/io_init.c EXPORT_SYMBOL(sn_pci_unfixup_slot); · line 719

Quoted 7 lines
arch/ia64/sn/kernel/io_init.c +0 -1
@@ -716,4 +716,3 @@ EXPORT_SYMBOL(sn_pci_unfixup_slot);
 EXPORT_SYMBOL(sn_pci_controller_fixup);
 EXPORT_SYMBOL(sn_bus_store_sysdata);
 EXPORT_SYMBOL(sn_bus_free_sysdata);
-EXPORT_SYMBOL(sn_pcidev_info_get);

---end quoted text---

author
#5 lore raw
In reply to Christoph Hellwig
Quoted 7 lines · Christoph Hellwig
Quoted 1 line · Mark Maule

Export sn_pcidev_info_get.

Tony or Andrew please back this out again. The only reason SGI wants this is to support their illegal graphics driver, and no core code uses it.

And Mark, please stop submitting such patches.

All I'm doing by exporting sn_pcidev_info_get is allowing a module to use the SGI SN_PCIDEV_BUSSOFT() macro which will tell a driver which piece of altix PCI hw its device is sitting behind (e.g. PCIIO_ASIC_TYPE_TIOCP et. al).

While I acknowledge that the gfx driver folks requested this, I don't understand what is "illegal" about this export, or the driver which wants to use it. What am I missing here?

Mark

#6 lore raw
Quoted 9 lines · Mark Maule
Quoted 7 lines · Christoph Hellwig
Quoted 1 line · Mark Maule

Export sn_pcidev_info_get.

Tony or Andrew please back this out again. The only reason SGI wants this is to support their illegal graphics driver, and no core code uses it.

And Mark, please stop submitting such patches.

Quoted 7 lines

All I'm doing by exporting sn_pcidev_info_get is allowing a module to use the SGI SN_PCIDEV_BUSSOFT() macro which will tell a driver which piece of altix PCI hw its device is sitting behind (e.g. PCIIO_ASIC_TYPE_TIOCP et. al).

While I acknowledge that the gfx driver folks requested this, I don't understand what is "illegal" about this export, or the driver which wants to use it. What am I missing here?

so you would have no objection to making this a _GPL export ?

#7 lore raw
Quoted 22 lines · Arjan van de Ven
Quoted 19 lines · Mark Maule
Quoted 12 lines · Christoph Hellwig
Quoted 3 lines · Mark Maule

Export sn_pcidev_info_get.

Tony or Andrew please back this out again. The only reason SGI wants this is to support their illegal graphics driver, and no core code uses it.

And Mark, please stop submitting such patches.

All I'm doing by exporting sn_pcidev_info_get is allowing a module to use the SGI SN_PCIDEV_BUSSOFT() macro which will tell a driver which piece of altix PCI hw its device is sitting behind (e.g. PCIIO_ASIC_TYPE_TIOCP et. al).

Quoted 8 lines
Quoted 5 lines

While I acknowledge that the gfx driver folks requested this, I don't understand what is "illegal" about this export, or the driver which wants to use it. What am I missing here?

so you would have no objection to making this a _GPL export ?

Hi Folks,

sn_* symbols are "their" symbols so I can't see any legitimation for anyone else to not let them export their symbols as they want. They are doing a great job on linux to make it run scalable on the biggest machines on earth. Or don't you like the idea of running Linux on those supercomputers?

Christian

#8 lore raw
In reply to Mark Maule
Quoted 4 lines · Mark Maule
Quoted 3 lines · Christoph Hellwig
Quoted 1 line · Mark Maule

Export sn_pcidev_info_get.

Quoted 8 lines
Quoted 4 lines

Tony or Andrew please back this out again. The only reason SGI wants this is to support their illegal graphics driver, and no core code uses it.

And Mark, please stop submitting such patches.

All I'm doing by exporting sn_pcidev_info_get is allowing a module to use the SGI SN_PCIDEV_BUSSOFT() macro which will tell a driver which piece of altix PCI hw its device is sitting behind (e.g. PCIIO_ASIC_TYPE_TIOCP et. al).

And that's absolutely not something a driver should care about. If you illegal binary driver uses it it's totally broken (but then we knew that before anyway ;-))

#9 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Christoph" = Christoph Hellwig <[email protected]> writes:

Quoted 4 lines · Mark Maule
Quoted 4 lines

All I'm doing by exporting sn_pcidev_info_get is allowing a module to use the SGI SN_PCIDEV_BUSSOFT() macro which will tell a driver which piece of altix PCI hw its device is sitting behind (e.g. PCIIO_ASIC_TYPE_TIOCP et. al).

Christoph> And that's absolutely not something a driver should care Christoph> about. If you illegal binary driver uses it it's totally Christoph> broken (but then we knew that before anyway ;-))

Christoph,

Leaving the issues around the specific client aside here.

Any chance you could explain why some drivers in drivers/net use the arch defines to set things like optimial burst sizes then? Drivers such as acenic.c, fealnx.c and starfire.c do this based on the arch even though it really is a property of the combination of the PCI bus, CPU and memory busses in the specific systems.

Were you planning on posting a patch to remove all of those instances while you were at it?

Point is that there are cases where tuning requires you to know what PCI bridge is below you in order to get the best performance out of a card. One can keep a PCI ID blacklist to handle tuning of the PCI bridge itself, but it can't handle things that needs to be tuned by setting the PCI device's own registers.

Having a generic API to export this information would be a good thing IMHO.

Cheers,
Jes

#10 lore raw
Quoted 8 lines · Jes Sorensen

Point is that there are cases where tuning requires you to know what PCI bridge is below you in order to get the best performance out of a card. One can keep a PCI ID blacklist to handle tuning of the PCI bridge itself, but it can't handle things that needs to be tuned by setting the PCI device's own registers.

Having a generic API to export this information would be a good thing IMHO.

So please submit a patch to add querying/tuning pci bridges. And please make it _GPL exports so people don't accidentally use it in their illegal drivers.

#11 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Christoph" = Christoph Hellwig <[email protected]> writes:

Christoph> On Tue, Feb 21, 2006 at 06:23:12AM -0500, Jes Sorensen

Quoted 8 lines · Christoph> wrote:
Quoted 8 lines

Point is that there are cases where tuning requires you to know what PCI bridge is below you in order to get the best performance out of a card. One can keep a PCI ID blacklist to handle tuning of the PCI bridge itself, but it can't handle things that needs to be tuned by setting the PCI device's own registers.

Having a generic API to export this information would be a good thing IMHO.

Christoph> So please submit a patch to add querying/tuning pci Christoph> bridges. And please make it _GPL exports so people don't Christoph> accidentally use it in their illegal drivers.

Mark checked with the gfx people and it seems that the requirement for this information was a leftover from an older codebase and they don't actually need it anymore. Anyway, I'm not sure what illegal drivers you keep referring to.

Tony/Andrew, it should be ok to take the export out again.

I'll try to look into doing a more generic interface for querying information about the low level PCI briges at some point. Since there's no new users screaming for this right now and most current drivers that will benefit from it are somewhat old, it's not going to be my top priority item at this moment. Since this would be an interface, it would obviously have to a regular symbol export.

Cheers,
Jes