Skip to contentSkip to conversation

mm/slab: unexport kmem_cache_alloc_node

PATCH In review Adrian Bunk 2 participants 2 messages Feb 20, 2006 – Feb 21, 2006 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/slab: unexport kmem_cache_alloc_node

I didn't find any modular usage of kmem_cache_alloc_node.

---

This patch was already sent on:
- 27 Jul 2005
- 2 Jul 2005
- 21 Jun 2005
- 30 May 2005
- 15 May 2005

mm/slab.c renamed from mm/slab.c.old +0 -1
@@ -2431,7 +2440,6 @@
 					__builtin_return_address(0));
 	return objp;
 }
-EXPORT_SYMBOL(kmem_cache_alloc_node);
 
 #endif
 
#1 lore raw
Quoted 17 lines · Adrian Bunk

I didn't find any modular usage of kmem_cache_alloc_node.

---

This patch was already sent on:
- 27 Jul 2005
- 2 Jul 2005
- 21 Jun 2005
- 30 May 2005
- 15 May 2005

mm/slab.c line 2445

Quoted 7 lines
mm/slab.c renamed from mm/slab.c.old +0 -1
@@ -2431,7 +2440,6 @@
 					__builtin_return_address(0));
 	return objp;
 }
-EXPORT_SYMBOL(kmem_cache_alloc_node);
 
 #endif
 

kmem_cache_alloc_node() is part of the slab API and it is reasonable that it be exported in this manner along with the rest of that API. If someone wanted to use kmem_cache_alloc_node() and found it wasn't exported like the rest of the slab functions, that would look weird.

So I don't think we need bother going through the drawn-out pain of retracting an export which has been in-tree for a year or so.