Skip to contentSkip to conversation

au1xmmc: fix mmc_rsp_type typo

PATCH In review Domen Puncer 3 participants 4 messages Feb 21, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 au1xmmc: fix mmc_rsp_type typo

Patch that added this suggests mmc_rsp_type should be mmc_resp_type.

 drivers/mmc/au1xmmc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/au1xmmc.c +1 -1
Index: linux-2.6.16-rc4.git/drivers/mmc/au1xmmc.c
===================================================================
@@ -195,7 +195,7 @@ static int au1xmmc_send_command(struct a
 
 	u32 mmccmd = (cmd->opcode << SD_CMD_CI_SHIFT);
 
-	switch (mmc_rsp_type(cmd->flags)) {
+	switch (mmc_resp_type(cmd->flags)) {
 	case MMC_RSP_R1:
 		mmccmd |= SD_CMD_RT_1;
 		break;
#1 lore raw
Quoted 1 line · Domen Puncer

Patch that added this suggests mmc_rsp_type should be mmc_resp_type.

Ouch, I thought I compile tested.
Here's a fixed version:

There's no mmc_rsp_type

drivers/mmc/au1xmmc.c +2 -1
Index: linux-2.6.16-rc4.git/drivers/mmc/au1xmmc.c
===================================================================
@@ -41,6 +41,7 @@
 #include <linux/mm.h>
 #include <linux/interrupt.h>
 #include <linux/dma-mapping.h>
+#include <linux/platform_device.h>
 
 #include <linux/mmc/host.h>
 #include <linux/mmc/protocol.h>
@@ -195,7 +195,7 @@ static int au1xmmc_send_command(struct a
 
 	u32 mmccmd = (cmd->opcode << SD_CMD_CI_SHIFT);
 
-	switch (mmc_rsp_type(cmd->flags)) {
+	switch (mmc_resp_type(cmd)) {
 	case MMC_RSP_R1:
 		mmccmd |= SD_CMD_RT_1;
 		break;
#2 lore raw
Quoted 4 lines · Domen Puncer
Quoted 1 line

Patch that added this suggests mmc_rsp_type should be mmc_resp_type.

Ouch, I thought I compile tested.
Here's a fixed version:

Jordan?

Ralf

#3 lore raw
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Patch that added this suggests mmc_rsp_type should be mmc_resp_type.

Ouch, I thought I compile tested.
Here's a fixed version:

Jordan?

Looks good to me. Thanks Domen.

Jordan

Signature · 4 lines
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>