Skip to contentSkip to conversation

ocfs2: actually free hb set on cluster removal

PATCH New Jeff Mahoney 2 participants 2 messages Feb 21, 2006 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 7/14 ocfs2: actually free hb set on cluster removal

This patch actually frees the hb set when the cluster dir is removed.

 fs/ocfs2/cluster/nodemanager.c |    1 +
 1 files changed, 1 insertion(+)
fs/ocfs2/cluster/nodemanager.c +1 -0
diff -ruNpX ../dontdiff linux-2.6.16-rc4.ocfs2-staging1/fs/ocfs2/cluster/nodemanager.c linux-2.6.16-rc4.ocfs2-staging2/fs/ocfs2/cluster/nodemanager.c
@@ -701,6 +701,7 @@ static void o2nm_cluster_group_drop_item
 	BUG_ON(o2nm_single_cluster != cluster);
 	o2nm_single_cluster = NULL;
 
+	o2hb_free_hb_set(cluster->cl_group.default_groups[1]);
 	for (i = 0; cluster->cl_group.default_groups[i]; i++) {
 		killme = &cluster->cl_group.default_groups[i]->cg_item;
 		cluster->cl_group.default_groups[i] = NULL;
#1 lore raw

PATCH 7/14 ocfs2: actually free hb set on cluster removal

Quoted 2 lines · Jeff Mahoney

This patch actually frees the hb set when the cluster dir is removed.

shouldn't this as a fix be first in the series before your new features? In fact for future postings it would be nice if you sent a [PATCH x/n] series for fixes, and a second [PATCH x/n series for features.