Skip to contentSkip to conversation

ARM: OMAP: Add external LCD controller support for DSP Gateway

DISCUSSION Komal Shah 1 participant 1 message Feb 21, 2006

lore
Share & tools
lore

Komal Shah

author
#0 lore raw

Juha,

+ status = omapfb_unregister_client(omapfb_nb);
+ if (!status)
+ printk("omapfb_unregister_client(): "
+ "success\n");
+ else
+ printk("omapfb_runegister_client(): "
+ "failure(%d)\n", status);

You might want to add KERN_WARNING or KERN_INFO for above printks and other locations of printks in the patch where it is missing.

+ }
+ //printk("calling omapfb_update_window_async()\n");
+ omapfb_update_window_async(&win, fbupd_cb, NULL);

c++ style comment. May be you would like to remove that printk itself.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com