Skip to contentSkip to conversation

2.6.16-rc4: known regressions

RFC PATCH New Yu, Luming 2 participants 3 messages Feb 22, 2006 – Feb 25, 2006

Subsystems (2)
lore
Share & tools
lore

Yu, Luming

author
#0 lore raw
Quoted 6 lines
Quoted 6 lines

Subject : S3 sleep hangs the second time - 600X

Quoted 4 lines

References : http://bugzilla.kernel.org/show_bug.cgi?id=5989
Submitter : Sanjoy Mahajan <[email protected]>
Status : problematic commit identified,
further discussion is in the bug

Quoted 8 lines
Quoted 2 lines

The real problem is there are some bugs hidden by ec_intr=0. ec_intr=1 just get these bug just exposed, and we need to fix them.

From a users' point of view, these are regressions from 2.6.15, and not
all of them might be fixed in time for 2.6.16.

What is a possible short term solution/workaround for 2.6.16?

ec_intr=0 is a reasonable workaround for this box, if we couldn't root-cause and fix the real problem on time.

Quoted 2 lines

Can we go back to default to polling mode in 2.6.16?

No, don't do this. There are other laptops need this. And I didn't get regression report that is root-caused to enabling ec_intr=1 by default. If you argue bug 5989, 6075 could be, I think the truth is, for 5989, we need to fix thermal and processor driver issue.
for 6075, we need to fix interrupt issue.

So far, I don't think we need o fall back.

Thanks,
Luming

.

#1 lore raw
Quoted 18 lines · Luming
Quoted 6 lines
Quoted 6 lines

Subject : S3 sleep hangs the second time - 600X

Quoted 4 lines

References : http://bugzilla.kernel.org/show_bug.cgi?id=5989
Submitter : Sanjoy Mahajan <[email protected]>
Status : problematic commit identified,
further discussion is in the bug

Quoted 8 lines
Quoted 2 lines

The real problem is there are some bugs hidden by ec_intr=0. ec_intr=1 just get these bug just exposed, and we need to fix them.

From a users' point of view, these are regressions from 2.6.15, and not
all of them might be fixed in time for 2.6.16.

What is a possible short term solution/workaround for 2.6.16?

ec_intr=0 is a reasonable workaround for this box, if we couldn't root-cause and fix the real problem on time.

Quoted 7 lines
Quoted 1 line

Can we go back to default to polling mode in 2.6.16?

No, don't do this. There are other laptops need this. And I didn't get regression report that is root-caused to enabling ec_intr=1 by default. If you argue bug 5989, 6075 could be, I think the truth is, for 5989, we need to fix thermal and processor driver issue.

We do both agree that defaulting to polling mode is not a long term solution.

The question is what to do until it's resolved - assuming that issues like 5989 might not be fixed in time for 2.6.16.

Breaking setups working with the defaults under 2.6.15 in 2.6.16 doesn't sound that good.

Quoted 1 line

for 6075, we need to fix interrupt issue.

As far as I understand 6075, the submitter already tried ec_intr=0 without success.

Quoted 4 lines

So far, I don't think we need o fall back.

Thanks,
Luming

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw

RFC PATCH 1/1 drivers/acpi/ec.c: default to polling mode for 2.6.16

Quoted 33 lines · Adrian Bunk
Quoted 18 lines · Luming
Quoted 6 lines
Quoted 6 lines

Subject : S3 sleep hangs the second time - 600X

Quoted 4 lines

References : http://bugzilla.kernel.org/show_bug.cgi?id=5989
Submitter : Sanjoy Mahajan <[email protected]>
Status : problematic commit identified,
further discussion is in the bug

Quoted 8 lines
Quoted 2 lines

The real problem is there are some bugs hidden by ec_intr=0. ec_intr=1 just get these bug just exposed, and we need to fix them.

From a users' point of view, these are regressions from 2.6.15, and not
all of them might be fixed in time for 2.6.16.

What is a possible short term solution/workaround for 2.6.16?

ec_intr=0 is a reasonable workaround for this box, if we couldn't root-cause and fix the real problem on time.

Quoted 7 lines
Quoted 1 line

Can we go back to default to polling mode in 2.6.16?

No, don't do this. There are other laptops need this. And I didn't get regression report that is root-caused to enabling ec_intr=1 by default. If you argue bug 5989, 6075 could be, I think the truth is, for 5989, we need to fix thermal and processor driver issue.

We do both agree that defaulting to polling mode is not a long term solution.

The question is what to do until it's resolved - assuming that issues like 5989 might not be fixed in time for 2.6.16.

Quoted 8 lines

Breaking setups working with the defaults under 2.6.15 in 2.6.16 doesn't sound that good.

Quoted 1 line

for 6075, we need to fix interrupt issue.

As far as I understand 6075, the submitter already tried ec_intr=0 without success.
...

Let me suggest the following patch for going back to default to polling mode in 2.6.16.

The idea is to get this patch into 2.6.16, immediately revert it in Len's ACPI tree, and properly fix all issues before 2.6.17.

This way, there will be less regressions when the changed default is in a stable kernel.

cu
Adrian

<-- snip -->

The changed default seems to cause regressions (see
http://bugzilla.kernel.org/show_bug.cgi?id=5989).

Let's change the default back to polling mode for one more stable kernel.

---

 Documentation/kernel-parameters.txt |    4 ++--
 drivers/acpi/ec.c                   |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Documentation/kernel-parameters.txt renamed from Documentation/kernel-parameters.txt.old +2 -2
@@ -460,8 +460,8 @@
 
 	ec_intr=	[HW,ACPI] ACPI Embedded Controller interrupt mode
 			Format: <int>
-			0: polling mode
-			non-0: interrupt mode (default)
+			0: polling mode (default)
+			non-0: interrupt mode
 
 	eda=		[HW,PS2]
 
drivers/acpi/ec.c renamed from drivers/acpi/ec.c.old +2 -2
@@ -73,7 +73,7 @@
 	.class = ACPI_EC_CLASS,
 	.ids = ACPI_EC_HID,
 	.ops = {
-		.add = acpi_ec_intr_add,
+		.add = acpi_ec_poll_add,
 		.remove = acpi_ec_remove,
 		.start = acpi_ec_start,
 		.stop = acpi_ec_stop,
@@ -147,7 +147,7 @@
 
 /* External interfaces use first EC only, so remember */
 static struct acpi_device *first_ec;
-static int acpi_ec_poll_mode = EC_INTR;
+static int acpi_ec_poll_mode = EC_POLL;
 
 /* --------------------------------------------------------------------------
                              Transaction Management