flags parameter for linkat
PATCH 1/1 flags parameter for linkat
I'm currently at the POSIX meeting and one thing covered was the incompatibility of Linux's link() with the POSIX definition. The difference is the treatment of symbolic links in the destination name. Linux does not follow symlinks, POSIX requires it does.
Even somebody thinks this is a good default behavior we cannot change this because it would break the ABI. But the fact remains that some application might want this behavior.
We have one chance to help implementing this without breaking the behavior. For this we could use the new linkat interface which would need a new flags parameter. If the new parameter is AT_SYMLINK_FOLLOW the new behavior could be invoked.
I do not want to introduce such a patch now. But we could add the parameter now, just don't use it. The patch below would do this. Can we get this late patch applied before the release more or less fixes the syscall API?
namei.c-new renamed from namei.c +6 -2
@@ -2232,13 +2232,17 @@ * and other special files. --ADM */ asmlinkage long sys_linkat(int olddfd, const char __user *oldname, - int newdfd, const char __user *newname) + int newdfd, const char __user *newname, + int flags) { struct dentry *new_dentry; struct nameidata nd, old_nd; int error; char * to; + if (flags != 0) + return -EINVAL; + to = getname(newname); if (IS_ERR(to)) return PTR_ERR(to);
@@ -2271,7 +2275,7 @@ asmlinkage long sys_link(const char __user *oldname, const char __user *newname) { - return sys_linkat(AT_FDCWD, oldname, AT_FDCWD, newname); + return sys_linkat(AT_FDCWD, oldname, AT_FDCWD, newname, 0); } /*
arch/s390/kernel/compat_wrapper.S renamed from arch/s390/kernel/compat_wrapper.S-new +0 -1
@@ -1552,7 +1552,6 @@ llgtr %r3,%r3 # const char * lgfr %r4,%r4 # int llgtr %r5,%r5 # const char * - lgfr %r6,%r6 # int jg sys_linkat .globl sys_symlinkat_wrapper
arch/s390/kernel/compat_wrapper.S line 1555
Quoted 9 lines · Ulrich Drepper
arch/s390/kernel/compat_wrapper.S renamed from arch/s390/kernel/compat_wrapper.S-new +0
-1@@ -1552,7 +1552,6 @@ llgtr %r3,%r3 # const char * lgfr %r4,%r4 # int llgtr %r5,%r5 # const char * - lgfr %r6,%r6 # int jg sys_linkat
This hunk appears to be reversed.
David Vrabel
Quoted 14 lines · Ulrich Drepper
I'm currently at the POSIX meeting and one thing covered was the incompatibility of Linux's
link()with the POSIX definition. The difference is the treatment of symbolic links in the destination name. Linux does not follow symlinks, POSIX requires it does.Even somebody thinks this is a good default behavior we cannot change this because it would break the ABI. But the fact remains that some application might want this behavior.
We have one chance to help implementing this without breaking the behavior. For this we could use the new linkat interface which would need a new flags parameter. If the new parameter is
AT_SYMLINK_FOLLOWthe new behavior could be invoked.
Quoted 4 lines
I do not want to introduce such a patch now. But we could add the parameter now, just don't use it. The patch below would do this. Can we get this late patch applied before the release more or less fixes the syscall API?
The number of arguments changes, so below patch would be needed for 32-bit MIPS.
Ralf
arch/mips/kernel/scall32-o32.S +1 -1
@@ -626,7 +626,7 @@ einval: li v0, -EINVAL sys sys_fstatat64 4 sys sys_unlinkat 3 sys sys_renameat 4 /* 4295 */ - sys sys_linkat 4 + sys sys_linkat 5 sys sys_symlinkat 3 sys sys_readlinkat 4 sys sys_fchmodat 3
Quoted 14 lines · Ulrich Drepper
I'm currently at the POSIX meeting and one thing covered was the incompatibility of Linux's
link()with the POSIX definition. The difference is the treatment of symbolic links in the destination name. Linux does not follow symlinks, POSIX requires it does.Even somebody thinks this is a good default behavior we cannot change this because it would break the ABI. But the fact remains that some application might want this behavior.
We have one chance to help implementing this without breaking the behavior. For this we could use the new linkat interface which would need a new flags parameter. If the new parameter is
AT_SYMLINK_FOLLOWthe new behavior could be invoked.
Quoted 4 lines
I do not want to introduce such a patch now. But we could add the parameter now, just don't use it. The patch below would do this. Can we get this late patch applied before the release more or less fixes the syscall API?
Please stop adding these crappy flags argument everywhere, they're also creaping like a cancer through the other *at stuff. Just make linkat do the righ thing per posix spec for link, and then you can implement a posix link based on it in glibc if the user compiles with XOPEN_SOURCE or whatever.
Quoted 5 lines · Christoph Hellwig
Please stop adding these crappy flags argument everywhere, they're also creaping like a cancer through the other *at stuff. Just make linkat do the righ thing per posix spec for link, and then you can implement a posix link based on it in glibc if the user compiles with
XOPEN_SOURCEor whatever.
It's a bloody bad idea, since XOPEN_SOURCE is nowhere near fine-grained enough and could be forced by any number of things.
The _real_ issue with flags is the lack of filtering. I.e. we blindly pass userland argument there, exposing both internal flag values _and_ flags that really shouldn't be exposed that way at all.