Skip to contentSkip to conversation

softlockup-timer-driven.patch

PATCH New Ingo Molnar 1 participant 1 message Feb 24, 2006 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 softlockup-timer-driven.patch

below is the latest softdog-rework patch, with all fixes (including Nathan's hotplug CPU fix) merged.

--------
this patch makes the softlockup detector purely timer-interrupt driven, removing softirq-context (timer) dependencies. This means that if the softlockup watchdog triggers, it has truly observed a longer than 10 seconds scheduling delay of a SCHED_FIFO prio 99 task.

(the patch also turns off the softlockup detector during the initial bootup phase and does small style fixes)

----

 include/linux/sched.h |    4 +--
 kernel/softlockup.c   |   55 ++++++++++++++++++++++++++++----------------------
 kernel/timer.c        |    2 -
 3 files changed, 34 insertions(+), 27 deletions(-)
include/linux/sched.h +2 -2
Index: linux/include/linux/sched.h
===================================================================
@@ -207,11 +207,11 @@ extern void update_process_times(int use
 extern void scheduler_tick(void);
 
 #ifdef CONFIG_DETECT_SOFTLOCKUP
-extern void softlockup_tick(struct pt_regs *regs);
+extern void softlockup_tick(void);
 extern void spawn_softlockup_task(void);
 extern void touch_softlockup_watchdog(void);
 #else
-static inline void softlockup_tick(struct pt_regs *regs)
+static inline void softlockup_tick(void)
 {
 }
 static inline void spawn_softlockup_task(void)
kernel/softlockup.c +31 -24

121 lines not on this page · raw message

kernel/timer.c +1 -1
Index: linux/kernel/timer.c
===================================================================
@@ -869,6 +869,7 @@ static void run_timer_softirq(struct sof
 void run_local_timers(void)
 {
 	raise_softirq(TIMER_SOFTIRQ);
+	softlockup_tick();
 }
 
 /*
@@ -897,7 +898,6 @@ void do_timer(struct pt_regs *regs)
 {
 	jiffies_64++;
 	update_times();
-	softlockup_tick(regs);
 }
 
 #ifdef __ARCH_WANT_SYS_ALARM