Skip to contentSkip to conversation

x86_64: don't use early_printk() during memory init

PATCH In review Chuck Ebbert 2 participants 2 messages Feb 25, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86_64: don't use early_printk() during memory init

printk is working by the time this memory init message prints. As it stands, output jumps to the top of the screen and prints this message, then back to normal boot messages, overwriting a line at the top.

---

This bug was introduced 5 weeks ago and should be fixed before 2.6.16.

arch/x86_64/mm/init.c +1 -1
@@ -312,7 +312,7 @@ static void __init find_early_table_spac
 	table_start >>= PAGE_SHIFT;
 	table_end = table_start;
 
-	early_printk("kernel direct mapping tables up to %lx @ %lx-%lx\n",
+	printk("kernel direct mapping tables up to %lx @ %lx-%lx\n",
 		end, table_start << PAGE_SHIFT, table_end << PAGE_SHIFT);
 }
 
Signature · 2 lines
Chuck
"Equations are the Devil's sentences."  --Stephen Colbert
#1 lore raw
Quoted 4 lines · Chuck Ebbert

printk is working by the time this memory init message prints. As it stands, output jumps to the top of the screen and prints this message, then back to normal boot messages, overwriting a line at the top.

Using of early_printk here was intentional because it needs much less infrastructure than printk and is pretty good proof that the kernel at least started.

So please don't apply the patch.

-Andi