Skip to contentSkip to conversation

x86: start early_printk at sensible screen row

PATCH In review Chuck Ebbert 2 participants 2 messages Feb 25, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: start early_printk at sensible screen row

Use boot info to start early_printk() at the proper row on VGA console.

arch/x86_64/kernel/early_printk.c +1 -1
@@ -244,7 +244,7 @@ int __init setup_early_printk(char *opt)
 	           && SCREEN_INFO.orig_video_isVGA == 1) {
 		max_xpos = SCREEN_INFO.orig_video_cols;
 		max_ypos = SCREEN_INFO.orig_video_lines;
-		current_ypos = max_ypos;
+		current_ypos = SCREEN_INFO.orig_y;
 		early_console = &early_vga_console; 
  	} else if (!strncmp(buf, "simnow", 6)) {
  		simnow_init(buf + 6);
Signature · 2 lines
Chuck
"Equations are the Devil's sentences."  --Stephen Colbert
#1 lore raw
Quoted 3 lines · Chuck Ebbert

Use boot info to start early_printk() at the proper row on VGA console.

Define "proper".

arch/x86_64/kernel/early_printk.c int __init setup_early_printk(char *opt) · line 250

Quoted 12 lines
arch/x86_64/kernel/early_printk.c +1 -1
@@ -244,7 +244,7 @@ int __init setup_early_printk(char *opt)
 	           && SCREEN_INFO.orig_video_isVGA == 1) {
 		max_xpos = SCREEN_INFO.orig_video_cols;
 		max_ypos = SCREEN_INFO.orig_video_lines;
-		current_ypos = max_ypos;
+		current_ypos = SCREEN_INFO.orig_y;
 		early_console = &early_vga_console; 
  	} else if (!strncmp(buf, "simnow", 6)) {
  		simnow_init(buf + 6);

Is that the place at which the boot loader left the cursor?