Skip to contentSkip to conversation

Duplicated request_region code in arch/powerpc and arch/ppc

KJ Tim Cooijmans 2 participants 2 messages Feb 25, 2006 Kernel janitors

lore
Share & tools
lore
#0 lore raw

These files all request the same regions, namely dma1, dma2, dma page reg, pic1, pic2 and timer:

arch/powerpc/platforms/chrp/setup.c
arch/powerpc/platforms/pseries/pci.c
arch/ppc/platforms/chrp_setup.c
arch/ppc/platforms/lopec.c
arch/ppc/platforms/mvme5100.c
arch/ppc/platforms/pplus.c
arch/ppc/platforms/sandpoint.c

Should these requests be moved to a central function? If so, what should the function be called (i.e., why are the regions requested) and where should it be defined?

Tim

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

hi tim,
chrp means "Common Hardware Reference Platform" therefore several boards can be exspected to have same design. I would add this as default_chrp_setup() into chrp_setup.c.

just my 2 cents,
re, walter

Quoted 18 lines · Tim Cooijmans

These files all request the same regions, namely dma1, dma2, dma page reg, pic1, pic2 and timer:

arch/powerpc/platforms/chrp/setup.c
arch/powerpc/platforms/pseries/pci.c
arch/ppc/platforms/chrp_setup.c
arch/ppc/platforms/lopec.c
arch/ppc/platforms/mvme5100.c
arch/ppc/platforms/pplus.c
arch/ppc/platforms/sandpoint.c

Should these requests be moved to a central function? If so, what should the function be called (i.e., why are the regions requested) and where should it be defined?

Tim

Quoted 6 lines

------------------------------------------------------------------------

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors