fix build breakage in eeh.c in 2.6.16-rc5-git5
This patch should fixe a problem with eeh_add_device_late() not being defined in the ppc64 build process, causing the build to break.
--- include/asm-powerpc/eeh.h | 1 + 1 files changed, 1 insertion(+)
include/asm-powerpc/eeh.h +1 -0
@@ -61,6 +61,7 @@* to finish the eeh setup for this device. */ void eeh_add_device_early (struct device_node *); +void eeh_add_device_late (struct pci_dev *dev);void eeh_add_device_tree_early (struct device_node *);void eeh_add_device_tree_late (struct pci_bus *);
Quoted 2 lines · Greg KH
This patch should fixe a problem with
eeh_add_device_late()not being defined in the ppc64 build process, causing the build to break.
John Rose just sent a patch making eeh_add_device_late static and moving it to be defined before it is called in arch/powerpc/platforms/pseries/eeh.c.
Since he maintains this stuff, I'm more inclined to take his patch.
Paul.
Quoted 10 lines · Paul Mackerras
Quoted 2 lines · Greg KH
This patch should fixe a problem with
eeh_add_device_late()not being defined in the ppc64 build process, causing the build to break.John Rose just sent a patch making
eeh_add_device_latestatic and moving it to be defined before it is called inarch/powerpc/platforms/pseries/eeh.c.Since he maintains this stuff, I'm more inclined to take his patch.
That's fine with me, as long as it makes it into 2.6.16-final :)
thanks,
greg k-h
Quoted 6 lines · Greg KH
Quoted 5 lines · Paul Mackerras
Quoted 2 lines · Greg KH
This patch should fixe a problem with
eeh_add_device_late()not being defined in the ppc64 build process, causing the build to break.
Quoted 7 lines
Quoted 5 lines
John Rose just sent a patch making
eeh_add_device_latestatic and moving it to be defined before it is called inarch/powerpc/platforms/pseries/eeh.c.Since he maintains this stuff, I'm more inclined to take his patch.
That's fine with me, as long as it makes it into 2.6.16-final :)
Hm, looks like my fix made it into Linus's tree, so you might want to send him the "correct" way to do this against that.
thanks,
greg k-h