Skip to contentSkip to conversation

EDAC: amd76x pci_dev_get/pci_dev_put fixes

PATCH In review Dave Peterson 1 participant 1 message Mar 3, 2006 EDAC-core

lore
Share & tools
lore
#0 lore raw

PATCH 4/15 EDAC: amd76x pci_dev_get/pci_dev_put fixes

Eliminate unnecessary calls to pci_dev_get() and pci_dev_put() from amd76x driver.

---

drivers/edac/amd76x_edac.c +2 -6
Index: linux-2.6.16-rc5-edac/drivers/edac/amd76x_edac.c
===================================================================
@@ -226,7 +226,7 @@ static int amd76x_probe1(struct pci_dev 
 
 	debugf0("%s(): mci = %p\n", __func__, mci);
 
-	mci->pdev = pci_dev_get(pdev);
+	mci->pdev = pdev;
 	mci->mtype_cap = MEM_FLAG_RDDR;
 
 	mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_EC | EDAC_FLAG_SECDED;
@@ -284,11 +284,8 @@ static int amd76x_probe1(struct pci_dev 
 	return 0;
 
 fail:
-	if (mci) {
-		if(mci->pdev)
-			pci_dev_put(mci->pdev);
+	if (mci != NULL)
 		edac_mc_free(mci);
-	}
 	return rc;
 }
 
@@ -322,7 +319,6 @@ static void __devexit amd76x_remove_one(
 		return;
 	if (edac_mc_del_mc(mci))
 		return;
-	pci_dev_put(mci->pdev);
 	edac_mc_free(mci);
 }