Skip to contentSkip to conversation

Portability fix for alsa-lib on mips

PATCH Applied Henryk Plötz 2 participants 2 messages Mar 2, 2006 – Mar 3, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Portability fix for alsa-lib on mips

Moin,

I recently had problems building alsa-lib 1.0.10 on mips (for my Netgear WGT634U). Turned out the problem was in include/alsa-symbols.h were there was __asm__ code that wouldn't work with the mips assembler. Attached is a patch that makes this work again.

(Normally I'd open a bug report, but the bugtracker seems to be dysfunctional currently.)

Signature · 4 lines
Henryk Plötz
Grüße aus Berlin
~~~~~~~ Un-CDs, nein danke! http://www.heise.de/ct/cd-register/ ~~~~~~~
~ Help Microsoft fight software piracy: Give Linux to a friend today! ~
include/alsa-symbols.h renamed from include/alsa-symbols.h.orig +1 -1
@@ -57,7 +57,7 @@
 	__asm__ (".set " #name "," #real);		\
 	__asm__ (".set ." #name ",." #real)
 #else
-#ifdef __alpha__
+#if defined(__alpha__) || defined(__mips__)
 #define use_default_symbol_version(real, name, version) \
         __asm__ (".weak " #name); \
         __asm__ (#name " = " #real)
Applied
#1 lore raw

At Fri, 3 Mar 2006 00:02:22 +0100,

Quoted 7 lines · Henryk Plötz

Moin,

I recently had problems building alsa-lib 1.0.10 on mips (for my Netgear WGT634U). Turned out the problem was in include/alsa-symbols.h were there was __asm__ code that wouldn't work with the mips assembler. Attached is a patch that makes this work again.

Thanks, applied to CVS now.

Quoted 3 lines

(Normally I'd open a bug report, but the bugtracker seems to be dysfunctional currently.)

In the case of patches, it's better to post to alsa-devel (and Cc to me or other ALSA developers), so that they can be caught up safely.

Takashi

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642