Corrected faulty syntax in drivers/input/Config.in
PATCH 1/1 Corrected faulty syntax in drivers/input/Config.in
From: "Stefan-W. Hahn" <[email protected]>
If statement in drivers/input/Config.in for "make xconfig" corrected.
---
This patch was sent by Stefan-W. Hahn on:
- 26 Feb 2006
drivers/input/Config.in +1 -1
@@ -8,7 +8,7 @@ comment 'Input core support' tristate 'Input core support' CONFIG_INPUT dep_tristate ' Keyboard support' CONFIG_INPUT_KEYBDEV $CONFIG_INPUT -if [ "$CONFIG_INPUT_KEYBDEV" == "n" ]; then +if [ "$CONFIG_INPUT_KEYBDEV" = "n" ]; then bool ' Use dummy keyboard driver' CONFIG_DUMMY_KEYB $CONFIG_INPUT fi
Quoted 14 lines
If statement in
drivers/input/Config.infor "make xconfig" corrected.Signed-off-by Stefan-W. Hahn <[email protected]>Signed-off-by Adrian Bunk <[email protected]>---
This patch was sent by Stefan-W. Hahn on:
- 26 Feb 2006
drivers/input/Config.in comment 'Input core support' · line 13
Quoted 7 lines
drivers/input/Config.in +1
-1@@ -8,7 +8,7 @@ comment 'Input core support' tristate 'Input core support' CONFIG_INPUT dep_tristate ' Keyboard support' CONFIG_INPUT_KEYBDEV $CONFIG_INPUT -if [ "$CONFIG_INPUT_KEYBDEV" == "n" ]; then +if [ "$CONFIG_INPUT_KEYBDEV" = "n" ]; then bool ' Use dummy keyboard driver' CONFIG_DUMMY_KEYB $CONFIG_INPUT fi
This was my patch, and after I saw that a bit later (Duh!), I did ask:
http://marc.theaimsgroup.com/?l=linux-kernel&m=112966037407189&w=2
But got no feedback, and it was accepted, so I presumed all was OK.
So it looks like breaks in xconfig, and not menuconfig (what I use).
Nick
Quoted 11 lines
Quoted 11 lines
If statement in
drivers/input/Config.infor "make xconfig" corrected.Signed-off-by Stefan-W. Hahn <[email protected]>Signed-off-by Adrian Bunk <[email protected]>drivers/input/Config.in +0
-0@@ -8,7 +8,7 @@ comment 'Input core support' tristate 'Input core support' CONFIG_INPUT dep_tristate ' Keyboard support' CONFIG_INPUT_KEYBDEV $CONFIG_INPUT
Quoted 4 lines
drivers/input/Config.in comment 'Input core support' · line 13
Quoted 4 lines
drivers/input/Config.in +1
-1-if [ "$CONFIG_INPUT_KEYBDEV" == "n" ]; then +if [ "$CONFIG_INPUT_KEYBDEV" = "n" ]; then bool ' Use dummy keyboard driver' CONFIG_DUMMY_KEYB $CONFIG_INPUT fi
If this is sh compatible code, then == is just as valid -- if xconfig breaks then, then xconfig is broken, not the file.
Jan Engelhardt
Quoted 11 lines · Jan Engelhardt
Quoted 11 lines
Quoted 11 lines
If statement in
drivers/input/Config.infor "make xconfig" corrected.Signed-off-by Stefan-W. Hahn <[email protected]>Signed-off-by Adrian Bunk <[email protected]>drivers/input/Config.in +0
-0@@ -8,7 +8,7 @@ comment 'Input core support' tristate 'Input core support' CONFIG_INPUT dep_tristate ' Keyboard support' CONFIG_INPUT_KEYBDEV $CONFIG_INPUT
Quoted 6 lines
Quoted 4 lines
drivers/input/Config.in comment 'Input core support' · line 13
Quoted 4 lines
drivers/input/Config.in +1
-1-if [ "$CONFIG_INPUT_KEYBDEV" == "n" ]; then +if [ "$CONFIG_INPUT_KEYBDEV" = "n" ]; then bool ' Use dummy keyboard driver' CONFIG_DUMMY_KEYB $CONFIG_INPUT fiIf this is sh compatible code, then == is just as valid -- if xconfig
It is not.
Quoted 1 line
breaks then, then xconfig is broken, not the file.
Please read at least the section "Introduction" of Documentation/kbuild/config-language.txt in kernel 2.4 instead of falsely accusing xconfig of being broken.
Quoted 1 line
Jan Engelhardt
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed