Skip to contentSkip to conversation

x86-64: Eliminate register_die_notifier symbol exported twice

PATCH Applied Kevin Winchester 4 participants 5 messages Mar 9, 2006 – Mar 10, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86-64: Eliminate register_die_notifier symbol exported twice

register_die_notifier is exported twice, once in traps.c and once in x8664_ksyms.c. This results in a warning on build.

arch/x86_64/kernel/x8664_ksyms.c 2006-03-09 19:40:46.000000000 -0400 renamed from arch/x86_64/kernel/x8664_ksyms.c 2006-03-09 19:34:11.000000000 -0400 +0 -0
@@ -142,7 +142,6 @@ EXPORT_SYMBOL(rwsem_down_write_failed_th

EXPORT_SYMBOL(empty_zero_page);

EXPORT_SYMBOL(die_chain);
-EXPORT_SYMBOL(register_die_notifier);

#ifdef CONFIG_SMP
EXPORT_SYMBOL(cpu_sibling_map);

Applied
#1 lore raw
Quoted 5 lines · Kevin Winchester

register_die_notifier is exported twice, once in traps.c and once in x8664_ksyms.c. This results in a warning on build.

Applied. Thanks.
-Andi

#2 lore raw
In reply to Kevin Winchester
Quoted 11 lines · On Thu, 09 Mar 2006 19:44:59 -0400 Kevin Winchester wrote:

register_die_notifier is exported twice, once in traps.c and once in x8664_ksyms.c. This results in a warning on build.

--- v2.6.16-rc5-mm3.orig/arch/x86_64/kernel/x8664_ksyms.c

2006-03-09 19:34:11.000000000 -0400

+++ v2.6.16-rc5-mm3/arch/x86_64/kernel/x8664_ksyms.c 2006-03-09
19:40:46.000000000 -0400

Review EXPORT_SYMBOL(rwsem_down_write_failed_th · line 147

Quoted 7 lines
(quoted diff) +0 -1
@@ -142,7 +142,6 @@ EXPORT_SYMBOL(rwsem_down_write_failed_th
 EXPORT_SYMBOL(empty_zero_page);
 
 EXPORT_SYMBOL(die_chain);
-EXPORT_SYMBOL(register_die_notifier);
 
 #ifdef CONFIG_SMP
 EXPORT_SYMBOL(cpu_sibling_map);

Thanks for that. However, I see 2 such warnings:

WARNING: vmlinux: 'register_die_notifier' exported twice. Previous export was in vmlinux
WARNING: vmlinux: 'strlen' exported twice. Previous export was in vmlinux

---
~Randy
Please use an email client that implements proper (compliant) threading. (You know who you are.)

#3 lore raw
Quoted 19 lines · Randy.Dunlap
Quoted 16 lines · On Thu, 09 Mar 2006 19:44:59 -0400 Kevin Winchester wrote:

register_die_notifier is exported twice, once in traps.c and once in x8664_ksyms.c. This results in a warning on build.

--- v2.6.16-rc5-mm3.orig/arch/x86_64/kernel/x8664_ksyms.c

2006-03-09 19:34:11.000000000 -0400

+++ v2.6.16-rc5-mm3/arch/x86_64/kernel/x8664_ksyms.c 2006-03-09
19:40:46.000000000 -0400

(quoted diff) +0 -1
@@ -142,7 +142,6 @@ EXPORT_SYMBOL(rwsem_down_write_failed_th
 EXPORT_SYMBOL(empty_zero_page);
 
 EXPORT_SYMBOL(die_chain);
-EXPORT_SYMBOL(register_die_notifier);
 
Quoted 8 lines

Review EXPORT_SYMBOL(rwsem_down_write_failed_th · line 147

Quoted 2 lines
(quoted diff) +0 -0
 #ifdef CONFIG_SMP
 EXPORT_SYMBOL(cpu_sibling_map);

Thanks for that. However, I see 2 such warnings:

WARNING: vmlinux: 'register_die_notifier' exported twice. Previous export was in vmlinux
WARNING: vmlinux: 'strlen' exported twice. Previous export was in vmlinux

They're all over the place. Some of them are due to -mm-only patches.

It's not very urgent. Let's get Sam's stuff settled down into mainline and get all such warnings in mainline fixed up first. That way, people will then know when their new patches are being bad and I'll know when -mm patches need fixups.

#4 lore raw
Quoted 20 lines · Andrew Morton
Quoted 19 lines · Randy.Dunlap
Quoted 16 lines · On Thu, 09 Mar 2006 19:44:59 -0400 Kevin Winchester wrote:

register_die_notifier is exported twice, once in traps.c and once in x8664_ksyms.c. This results in a warning on build.

--- v2.6.16-rc5-mm3.orig/arch/x86_64/kernel/x8664_ksyms.c

2006-03-09 19:34:11.000000000 -0400

+++ v2.6.16-rc5-mm3/arch/x86_64/kernel/x8664_ksyms.c 2006-03-09
19:40:46.000000000 -0400

(quoted diff) +0 -1
@@ -142,7 +142,6 @@ EXPORT_SYMBOL(rwsem_down_write_failed_th
 EXPORT_SYMBOL(empty_zero_page);
 
 EXPORT_SYMBOL(die_chain);
-EXPORT_SYMBOL(register_die_notifier);
 
Quoted 6 lines
Quoted 6 lines

Review EXPORT_SYMBOL(rwsem_down_write_failed_th · line 147

Quoted 2 lines
(quoted diff) +0 -0
 #ifdef CONFIG_SMP
 EXPORT_SYMBOL(cpu_sibling_map);

Thanks for that. However, I see 2 such warnings:

WARNING: vmlinux: 'register_die_notifier' exported twice. Previous

export was in vmlinux

Quoted 1 line
Quoted 1 line

WARNING: vmlinux: 'strlen' exported twice. Previous export was in

vmlinux

Quoted 5 lines
Quoted 1 line

They're all over the place. Some of them are due to -mm-only patches.

It's not very urgent. Let's get Sam's stuff settled down into mainline

and

Quoted 3 lines

get all such warnings in mainline fixed up first. That way, people will then know when their new patches are being bad and I'll know when -mm patches need fixups.

Fixing warnings like this is about the extent of my kernel abilities, so I figured I'd do it even if it isn't high priority. I do get the strlen warning as well, that was going to be tonight's task.

If it helps, I don't see any warnings on the -rc5 kernel. These two are the only ones I see.

Kevin