Skip to contentSkip to conversation

ipath - kbuild infrastructure

PATCH Roland Dreier 2 participants 5 messages Mar 9, 2006 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Review

Quoted 1 line
(quoted diff) +1 -0
+	depends on 64BIT && (PCIEPORTBUS || X86_HT)

Why do you depend on X86_HT? I think you got confused: the HT stands for hyperthreading, not hypertransport. In fact if you compile a kernel optimized for K8, X86_HT is disabled.

And why do you depend on PCIEPORTBUS? I don't see you using anything from the pcie_port_service stuff.

I think the correct thing for you to depend on is just "PCI", and build your whole driver (both pe800 and ht400) unconditionally. There's no special hypertransport or generic PCIe support config that you can test.

drivers/infiniband/hw/ipath/Makefile

Quoted 2 lines
drivers/infiniband/hw/ipath/Makefile new file +0 -0

I've been suggesting that new files be called "Kbuild", since Sam has deprecated the "Makefile" name.

Quoted 4 lines
drivers/infiniband/hw/ipath/Makefile new file +4 -0
+ipath_core-y :=
+
+ipath_core-y += ipath_copy.o
+ipath_core-y += ipath_diag.o

drivers/infiniband/hw/ipath/Makefile

Quoted 10 lines
drivers/infiniband/hw/ipath/Makefile new file +10 -0
+ipath_core-y += ipath_driver.o
+ipath_core-y += ipath_file_ops.o
+ipath_core-y += ipath_i2c.o
+ipath_core-y += ipath_init_chip.o
+ipath_core-y += ipath_intr.o
+ipath_core-y += ipath_layer.o
+ipath_core-y += ipath_sma.o
+ipath_core-y += ipath_stats.o
+ipath_core-y += ipath_sysfs.o
+ipath_core-y += ipath_user_pages.o

This is a very strange style. I would just put all the ipath_core-y stuff on one or two lines.

- R.

#2 lore raw
Quoted 8 lines · Roland Dreier

drivers/infiniband/hw/ipath/Makefile

Quoted 5 lines
(quoted diff) +1 -0
+	depends on 64BIT && (PCIEPORTBUS || X86_HT)
drivers/infiniband/hw/ipath/Makefile new file +0 -0

I've been suggesting that new files be called "Kbuild", since Sam has deprecated the "Makefile" name.

Eventually - yes.
But not just now. Kbuild was introduced because it was needed in the top-level directory and it made good sense to do so.
But for now keeping Makefile is a good choice. This is anyway what people are used to.

Sam

#3 lore raw

Sam> Eventually - yes. But not just now. Kbuild was introduced Sam> because it was needed in the top-level directory and it made Sam> good sense to do so. But for now keeping Makefile is a good Sam> choice. This is anyway what people are used to.

OK, disregard my suggestion then. Should we patch Documentation/kbuild/makefiles.txt to correct the current documentation, which says:

The preferred name for the kbuild files is 'Kbuild' but 'Makefile' will continue to be supported. All new developmen is expected to use the Kbuild filename.

- R.

#4 lore raw
Quoted 5 lines · Roland Dreier

Sam> Eventually - yes. But not just now. Kbuild was introduced Sam> because it was needed in the top-level directory and it made Sam> good sense to do so. But for now keeping Makefile is a good Sam> choice. This is anyway what people are used to.

Quoted 8 lines

OK, disregard my suggestion then. Should we patch Documentation/kbuild/makefiles.txt to correct the current documentation, which says:

The preferred name for the kbuild files is 'Kbuild' but 'Makefile' will continue to be supported. All new developmen is expected to use the Kbuild filename.

Yes - I will do so. Thanks.

Sam

#5 lore raw
In reply to Roland Dreier
Quoted 5 lines · Roland Dreier

Sam> Eventually - yes. But not just now. Kbuild was introduced Sam> because it was needed in the top-level directory and it made Sam> good sense to do so. But for now keeping Makefile is a good Sam> choice. This is anyway what people are used to.

Quoted 7 lines

OK, disregard my suggestion then. Should we patch Documentation/kbuild/makefiles.txt to correct the current documentation, which says:

The preferred name for the kbuild files is 'Kbuild' but 'Makefile' will continue to be supported. All new developmen is expected to use the Kbuild filename.

I've just checked in the following patch:

Documentation/kbuild/makefiles.txt +3 -3
index 99d51a5..a9c00fa 100644
@@ -106,9 +106,9 @@ This document is aimed towards normal de
 Most Makefiles within the kernel are kbuild Makefiles that use the
 kbuild infrastructure. This chapter introduce the syntax used in the
 kbuild makefiles.
-The preferred name for the kbuild files is 'Kbuild' but 'Makefile' will
-continue to be supported. All new developmen is expected to use the
-Kbuild filename.
+The preferred name for the kbuild files are 'Makefile' but 'Kbuild' can
+be used and if both a 'Makefile' and a 'Kbuild' file exists then the 'Kbuild'
+file will be used.
 
 Section 3.1 "Goal definitions" is a quick intro, further chapters provide
 more details, with real examples.