Skip to contentSkip to conversation

reiserfs/xattr_acl.c:reiserfs_get_acl(): make size an int

PATCH New Adrian Bunk 1 participant 1 message Mar 10, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reiserfs/xattr_acl.c:reiserfs_get_acl(): make size an int

The Coverity checker wasn't happy seeing a size_t compared with -ENODATA and -ENOSYS.

Since the only place where size is set is through the result of reiserfs_xattr_get() which is an int, we could simply make size an int.

fs/reiserfs/xattr_acl.c renamed from fs/reiserfs/xattr_acl.c.old +2 -2
@@ -182,7 +182,7 @@ struct posix_acl *reiserfs_get_acl(struc
 {
 	char *name, *value;
 	struct posix_acl *acl, **p_acl;
-	size_t size;
+	int size;
 	int retval;
 	struct reiserfs_inode_info *reiserfs_i = REISERFS_I(inode);
 
@@ -206,7 +206,7 @@ struct posix_acl *reiserfs_get_acl(struc
 		return posix_acl_dup(*p_acl);
 
 	size = reiserfs_xattr_get(inode, name, NULL, 0);
-	if ((int)size < 0) {
+	if (size < 0) {
 		if (size == -ENODATA || size == -ENOSYS) {
 			*p_acl = ERR_PTR(-ENODATA);
 			return NULL;