Skip to contentSkip to conversation

drivers/scsi/ahci.c:ahci_interrupt(): NULL pointer dereference

PATCH Applied Adrian Bunk 3 participants 3 messages Mar 10, 2006 – Mar 12, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

The Coverity checker spotted this bug (note the ap dereference)

<-- snip -->

...

                if (ap) {
...
                } else {
                        VPRINTK("port %u (no irq)\n", i);
                        if (ata_ratelimit()) {
                                struct pci_dev *pdev =
                                        to_pci_dev(ap->host_set->dev);

...

<-- snip -->

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw

PATCH 1/1 ahci: fix NULL pointer dereference detected by Coverity

Fix NULL pointer dereference detected by the Coverity checker. Kill dev -> pdev -> dev conversion while at it.

drivers/scsi/ahci.c +4 -10
@@ -778,23 +778,17 @@ static irqreturn_t ahci_interrupt (int i
 			struct ata_queued_cmd *qc;
 			qc = ata_qc_from_tag(ap, ap->active_tag);
 			if (!ahci_host_intr(ap, qc))
-				if (ata_ratelimit()) {
-					struct pci_dev *pdev =
-						to_pci_dev(ap->host_set->dev);
-					dev_printk(KERN_WARNING, &pdev->dev,
+				if (ata_ratelimit())
+					dev_printk(KERN_WARNING, host_set->dev,
 					  "unhandled interrupt on port %u\n",
 					  i);
-				}
 
 			VPRINTK("port %u\n", i);
 		} else {
 			VPRINTK("port %u (no irq)\n", i);
-			if (ata_ratelimit()) {
-				struct pci_dev *pdev =
-					to_pci_dev(ap->host_set->dev);
-				dev_printk(KERN_WARNING, &pdev->dev,
+			if (ata_ratelimit())
+				dev_printk(KERN_WARNING, host_set->dev,
 					"interrupt on disabled port %u\n", i);
-			}
 		}
 
 		irq_ack |= (1 << i);
Applied
#2 lore raw

Re: [PATCH] ahci: fix NULL pointer dereference detected by Coverity

Quoted 5 lines · Tejun Heo

Fix NULL pointer dereference detected by the Coverity checker. Kill dev -> pdev -> dev conversion while at it.

applied to #upstream-fixes