Skip to contentSkip to conversation

add __init declaration to mca functions

PATCH In review Chen, Kenneth W 2 participants 2 messages Mar 12, 2006 – Mar 15, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/6 add __init declaration to mca functions

Mark init related variable and functions with appropriate __init* declaration to mca functions.

arch/ia64/kernel/mca.c renamed from arch/ia64/kernel/mca.c.orig +6 -6
@@ -133,7 +133,7 @@ static int cpe_poll_enabled = 1;
 
 extern void salinfo_log_wakeup(int type, u8 *buffer, u64 size, int irqsafe);
 
-static int mca_init;
+static int mca_init __initdata;
 
 
 static void inline
@@ -184,7 +184,7 @@ static ia64_state_log_t ia64_state_log[I
  * Inputs   :   info_type   (SAL_INFO_TYPE_{MCA,INIT,CMC,CPE})
  * Outputs	:	None
  */
-static void
+static void __init
 ia64_log_init(int sal_info_type)
 {
 	u64	max_size = 0;
@@ -359,7 +359,7 @@ ia64_mca_cpe_int_handler (int cpe_irq, v
  *  Outputs
  *      None
  */
-static void
+static void __init
 ia64_mca_register_cpev (int cpev)
 {
 	/* Register the CPE interrupt vector with SAL */
@@ -392,7 +392,7 @@ ia64_mca_register_cpev (int cpev)
  * Outputs
  *	None
  */
-void
+void __cpuinit
 ia64_mca_cmc_vector_setup (void)
 {
 	cmcv_reg_t	cmcv;
@@ -1416,7 +1416,7 @@ static struct irqaction mca_cpep_irqacti
  * format most of the fields.
  */
 
-static void
+static void __cpuinit
 format_mca_init_stack(void *mca_data, unsigned long offset,
 		const char *type, int cpu)
 {
@@ -1440,7 +1440,7 @@ format_mca_init_stack(void *mca_data, un
 
 /* Do per-CPU MCA-related initialization.  */
 
-void __devinit
+void __cpuinit
 ia64_mca_cpu_init(void *cpu_data)
 {
 	void *pal_vaddr;
#1 lore raw
Quoted 9 lines · "Chen, Kenneth W" (on Sun, 12 Mar 2006 08:52:20 -0800) wrote:

Mark init related variable and functions with appropriate __init* declaration to mca functions.

arch/ia64/kernel/mca.c static int cpe_poll_enabled = 1; · line 136

Quoted 5 lines
arch/ia64/kernel/mca.c renamed from arch/ia64/kernel/mca.c.orig +1 -1
@@ -133,7 +133,7 @@ static int cpe_poll_enabled = 1;
 
 extern void salinfo_log_wakeup(int type, u8 *buffer, u64 size, int irqsafe);
 
-static int mca_init;
+static int mca_init __initdata;

Coding style niggle. Attributes like __initdata usually come before the variable name, for readibility.