Require VM86 with VESA framebuffer
PATCH 1/1 Require VM86 with VESA framebuffer
Force VM86 when VESA framebuffer is enabled and fix a typo in the VM86 config entry. If VM86 is disabled there will be problems when starting X using the VESA driver.
drivers/video/Kconfig +1 -0
@@ -456,6 +456,7 @@ config FB_TGA config FB_VESA bool "VESA VGA graphics support" depends on (FB = y) && X86 + select VM86 select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT
init/Kconfig +1 -1
@@ -224,7 +224,7 @@ config UID16 This enables the legacy 16-bit UID syscall wrappers. config VM86 - depends X86 + depends on X86 default y bool "Enable VM86 support" if EMBEDDED help
Signature · 2 lines
Chuck "Penguins don't come from next door, they come from the Antarctic!"
Quoted 3 lines · Chuck Ebbert
Force VM86 when VESA framebuffer is enabled and fix a typo in the VM86 config entry. If VM86 is disabled there will be problems when starting X using the VESA driver.
this sounds wrong.
The kernel works fine; it's X that needs vm86.. (but it needs that anyway).... but that's no reason to make one kernel option require another....
Quoted 11 lines · Arjan van de Ven
Quoted 3 lines · Chuck Ebbert
Force VM86 when VESA framebuffer is enabled and fix a typo in the VM86 config entry. If VM86 is disabled there will be problems when starting X using the VESA driver.
this sounds wrong.
The kernel works fine; it's X that needs vm86.. (but it needs that anyway).... but that's no reason to make one kernel option require another....
How does X solve it on x86-64? x86-64 has no vm86. I agree it is X that needs fixing.
Pavel
Signature · 1 line
199: private byte [] sbuffer;
Quoted 7 lines · Pavel Machek
Quoted 6 lines · Arjan van de Ven
Quoted 3 lines · Chuck Ebbert
Force VM86 when VESA framebuffer is enabled and fix a typo in the VM86 config entry. If VM86 is disabled there will be problems when starting X using the VESA driver.
Quoted 8 lines
Quoted 5 lines
this sounds wrong.
The kernel works fine; it's X that needs vm86.. (but it needs that anyway).... but that's no reason to make one kernel option require another....
How does X solve it on x86-64? x86-64 has no vm86. I agree it is X that needs fixing.
X has a complete enough x86 emulator for this stuff. Some builds of X don't use it on x86, but it works just fine; all other architectures use it always anyway
Quoted 3 lines · Chuck Ebbert
Force VM86 when VESA framebuffer is enabled and fix a typo in the VM86 config entry. If VM86 is disabled there will be problems when starting X using the VESA driver.
VESA does not require VM86 so this change is completely wrong. Worse still the x86-64 does not support VM86 so you have just crippled the x86-64 port unneccessarily.
Please sort out your personal X server problem instead. To start with X doesn't require VM86 to be present at all and can do software 8086 int 10 emulation for BIOS code.
Alan