Skip to contentSkip to conversation

Ext2 flags shouldn't report "nogrpid".

PATCH New Rob Landley 1 participant 1 message Mar 13, 2006 ext2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Ext2 flags shouldn't report "nogrpid".

If I mount ext2 "rw", I want it to say "rw", not "rw,nogrpid". --
I caught this writing an automated regression test script for the busybox mount command. The symptom is
/dev/loop0 on /images/ext2.dir type ext2 (rw,nogrpid)
instead of:
/dev/loop0 on /images/ext2.dir type ext2 (rw)

The behavior was introduced by git commit
8fc2751beb0941966d3a97b26544e8585e428c08.

Rob

Signature · 1 line
Never bet against the cheap plastic solution.
fs/ext2/super.c +0 -2
@@ -210,8 +210,6 @@
 
 	if (sbi->s_mount_opt & EXT2_MOUNT_GRPID)
 		seq_puts(seq, ",grpid");
-	else
-		seq_puts(seq, ",nogrpid");
 
 #if defined(CONFIG_QUOTA)
 	if (sbi->s_mount_opt & EXT2_MOUNT_USRQUOTA)