Fix irda-usb use after use
Don't read from free'd memory after calling netif_rx(). docopy is used as a boolean (0 and 1) so unsigned int is sufficient.
Coverity bug #928
Signed-off-by Eugene Teo <[email protected]>
drivers/net/irda/irda-usb.c renamed from drivers/net/irda/irda-usb.c~ +3 -2
@@ -740,7 +740,7 @@struct sk_buff *newskb;struct sk_buff *dataskb;struct urb *next_urb; -int docopy; +unsigned int len, docopy;IRDA_DEBUG (2 ,"%s(), len=%d\n" , __FUNCTION__, urb->actual_length);
@@ -851,10 +851,11 @@ dataskb->dev = self->netdev; dataskb->mac.raw = dataskb->data; dataskb->protocol =htons (ETH_P_IRDA ); + len = dataskb->len;netif_rx (dataskb);/* Keep stats up to date */ - self->stats.rx_bytes += dataskb->len; + self->stats.rx_bytes += len; self->stats.rx_packets++; self->netdev->last_rx = jiffies;
Signature · 2 lines
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }