fs/namespace.c:dup_namespace(): fix a use after free
The Coverity checker spotted the following bug in dup_namespace():
<-- snip -->
if (!new_ns->root) {
up_write(&namespace_sem);
kfree(new_ns);
goto out;
}
...
out:
return new_ns;<-- snip -->
Callers expect a non-NULL result to not be freed.
Signed-off-by Adrian Bunk <[email protected]>
fs/namespace.c renamed from fs/namespace.c.old +2 -3
@@ -1389,7 +1389,7 @@ struct namespace *dup_namespace(struct t new_ns =kmalloc (sizeof (struct namespace ),GFP_KERNEL );if (!new_ns) - goto out; +return NULL ;atomic_set (&new_ns->count,1 );INIT_LIST_HEAD (&new_ns->list);
@@ -1403,7 +1403,7 @@ struct namespace *dup_namespace(struct tif (!new_ns->root) {up_write (&namespace_sem);kfree (new_ns); - goto out; +return NULL ; }spin_lock (&vfsmount_lock);list_add_tail (&new_ns->list, &new_ns->root->mnt_list);
@@ -1444,7 +1444,6 @@ struct namespace *dup_namespace(struct tif (altrootmnt)mntput (altrootmnt); -out:return new_ns; }