Fix sequencer missing negative bound check
dev is missing a negative bound check.
sound/oss/sequencer.c renamed from sound/oss/sequencer.c~ +1 -1
@@ -713,7 +713,7 @@int i, l =0 ;unsigned char *buf = &event_rec[2 ]; -if ((int ) dev > max_synthdev) +if (dev <0 || dev >= max_synthdev)return ;if (!(synth_open_mask & (1 << dev)))return ;
Signature · 2 lines
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }Quoted 7 lines · Eugene Teo
dev is missing a negative bound check.
Signed-off-by Eugene Teo <[email protected]>
sound/oss/sequencer.c line 719
Quoted 8 lines
sound/oss/sequencer.c renamed from sound/oss/sequencer.c~ +1
-1@@ -713,7 +713,7 @@int i, l =0 ;unsigned char *buf = &event_rec[2 ]; -if ((int ) dev > max_synthdev) +if (dev <0 || dev >= max_synthdev)return ;if (!(synth_open_mask & (1 << dev)))return ;
Erm??
Looking at a bit more context for the function:
static void seq_sysex_message(unsigned char *event_rec)
{
int dev = event_rec[1];
int i, l = 0;
unsigned char *buf = &event_rec[2];
if ((int) dev > max_synthdev)
return;
if (!(synth_open_mask & (1 << dev)))
return;
if (!synth_devs[dev])
return;that 'int dev' came out of an 'unsigned char *' - as such, I doubt you can get a negative value. If anything, it should be 'unsigned int dev'.
Quoted 7 lines · Eugene Teo
dev is missing a negative bound check.
Signed-off-by Eugene Teo <[email protected]>
sound/oss/sequencer.c line 719
Quoted 8 lines
sound/oss/sequencer.c renamed from sound/oss/sequencer.c~ +1
-1@@ -713,7 +713,7 @@int i, l =0 ;unsigned char *buf = &event_rec[2 ]; -if ((int ) dev > max_synthdev) +if (dev <0 || dev >= max_synthdev)return ;if (!(synth_open_mask & (1 << dev)))return ;
Erm??
Looking at a bit more context for the function:
static void seq_sysex_message(unsigned char *event_rec)
{
int dev = event_rec[1];
int i, l = 0;
unsigned char *buf = &event_rec[2];
if ((int) dev > max_synthdev)
return;
if (!(synth_open_mask & (1 << dev)))
return;
if (!synth_devs[dev])
return;that 'int dev' came out of an 'unsigned char *' - as such, I doubt you can get a negative value. If anything, it should be 'unsigned int dev'.
<quote sender="[email protected]">
Quoted 4 lines · Eugene Teo
Quoted 3 lines
dev is missing a negative bound check.
Signed-off-by Eugene Teo <[email protected]>
[snipped]
Quoted 8 lines
static void
seq_sysex_message(unsigned char *event_rec){ int dev = event_rec[1]; int i, l = 0; unsigned char *buf = &event_rec[2]; if ((int) dev > max_synthdev) return;
[snipped]
Quoted 2 lines
that 'int dev' came out of an 'unsigned char *' - as such, I doubt you can get a negative value. If anything, it should be 'unsigned int dev'.
Yes, thanks for pointing it out.
--
'int dev' came out of an 'unsigned char *' - as such, it will not get a negative value. Thanks Valdis.
sound/oss/sequencer.c renamed from sound/oss/sequencer.c~ +1 -1
@@ -709,7 +709,7 @@static void seq_sysex_message (unsigned char *event_rec) { -int dev = event_rec[1 ]; +unsigned int dev = event_rec[1 ];int i, l =0 ;unsigned char *buf = &event_rec[2 ];
Signature · 10 lines
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642<quote sender="[email protected]">
Quoted 4 lines · Eugene Teo
Quoted 3 lines
dev is missing a negative bound check.
Signed-off-by Eugene Teo <[email protected]>
[snipped]
Quoted 8 lines
static void
seq_sysex_message(unsigned char *event_rec){ int dev = event_rec[1]; int i, l = 0; unsigned char *buf = &event_rec[2]; if ((int) dev > max_synthdev) return;
[snipped]
Quoted 2 lines
that 'int dev' came out of an 'unsigned char *' - as such, I doubt you can get a negative value. If anything, it should be 'unsigned int dev'.
Yes, thanks for pointing it out.
--
'int dev' came out of an 'unsigned char *' - as such, it will not get a negative value. Thanks Valdis.
sound/oss/sequencer.c renamed from sound/oss/sequencer.c~ +1 -1
@@ -709,7 +709,7 @@static void seq_sysex_message (unsigned char *event_rec) { -int dev = event_rec[1 ]; +unsigned int dev = event_rec[1 ];int i, l =0 ;unsigned char *buf = &event_rec[2 ];
Signature · 2 lines
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }