Skip to contentSkip to conversation

Fix vfs_inode dereference before NULL check

PATCH New Eugene Teo 1 participant 1 message Mar 16, 2006 9P file system

lore
Share & tools
lore

Eugene Teo

author
#0 lore raw

PATCH 1/1 Fix vfs_inode dereference before NULL check

__getname, which in turn will call kmem_cache_alloc, may return NULL.

Coverity bug #977

fs/9p/vfs_inode.c renamed from fs/9p/vfs_inode.c~ +2 -0
@@ -1254,6 +1254,8 @@
 		return -EINVAL;
 
 	name = __getname();
+	if (!name)
+		return -EINVAL;
 	/* build extension */
 	if (S_ISBLK(mode))
 		sprintf(name, "b %u %u", MAJOR(rdev), MINOR(rdev));
Signature · 2 lines
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265  9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }