Skip to contentSkip to conversation

telephony ixc missing return check for request_region()

PATCH New Laurent Wandrebeck 1 participant 1 message Mar 17, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 telephony ixc missing return check for request_region()

Hi,
in drivers/telephony/ixj.c, request_region() is called without checking the return value. Here is a simple patch to fix it.
Patch against 2.6.16-rc6-git8.
Please CC me on replies.
Regards.

drivers/telephony/ixj.c 2006-03-17 14:10:32.000000000 +0100 renamed from drivers/telephony/ixj.c.ori 2006-03-11 23:12:55.000000000 +0100 +4 -1
@@ -6802,7 +6802,10 @@ static int ixj_selfprobe(IXJ *j)
                        }
                } else if (j->dsp.low == 0x22) {
                        j->cardtype = QTI_PHONEJACK_PCI;
-                       request_region(j->XILINXbase, 4, "ixj control");
+                       if (!request_region(j->XILINXbase, 4, "ixj control")) {
+                               printk(KERN_INFO "ixj: can't get I/O address 0x%x\n", j->XILINXbase);
+                               return -1;
+                       }
                        j->pld_slicw.pcib.e1 = 1;
                        outb_p(j->pld_slicw.byte, j->XILINXbase);
                } else