Skip to contentSkip to conversation

+ stack-corruption-detector.patch added to -mm tree

DISCUSSION Rik van Riel 3 participants 4 messages Mar 9, 2006 – Mar 19, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Review

Quoted 2 lines · On Wed, 8 Mar 2006, [email protected] wrote:
(quoted diff) +1 -1
-			memset(ret, 0, THREAD_SIZE);		\
+			memset(ret, 0x55, THREAD_SIZE);		\

Xen uses 0x55 as a poison pattern too. I wonder if we should change this one (this one's newer ;)) to something else.

Signature · 1 line
All Rights Reversed
#2 lore raw
Quoted 7 lines · Rik van Riel

Review

Quoted 2 lines · On Wed, 8 Mar 2006, [email protected] wrote:
(quoted diff) +1 -1
-			memset(ret, 0, THREAD_SIZE);		\
+			memset(ret, 0x55, THREAD_SIZE);		\

Xen uses 0x55 as a poison pattern too. I wonder if we should change this one (this one's newer ;)) to something else.

I think we should have a central poison.h file.

Signature · 1 line
Mathematics is the supreme nostalgia of our time.
#3 lore raw
Quoted 10 lines · Matt Mackall
Quoted 7 lines · Rik van Riel

Review

Quoted 2 lines · On Wed, 8 Mar 2006, [email protected] wrote:
(quoted diff) +1 -1
-			memset(ret, 0, THREAD_SIZE);		\
+			memset(ret, 0x55, THREAD_SIZE);		\

Xen uses 0x55 as a poison pattern too. I wonder if we should change this one (this one's newer ;)) to something else.

I think we should have a central poison.h file.

sure

but it's not like xen is anywhere near mergable, so xen should change if anything ;)

#4 lore raw
Quoted 10 lines · Arjan van de Ven
Quoted 9 lines · Matt Mackall
Quoted 7 lines · Rik van Riel

Review

Quoted 2 lines · On Wed, 8 Mar 2006, [email protected] wrote:
(quoted diff) +1 -1
-			memset(ret, 0, THREAD_SIZE);		\
+			memset(ret, 0x55, THREAD_SIZE);		\

Xen uses 0x55 as a poison pattern too. I wonder if we should change this one (this one's newer ;)) to something else.

Quoted 6 lines
Quoted 1 line

I think we should have a central poison.h file.

sure

but it's not like xen is anywhere near mergable, so xen should change if anything ;)

Well Xen is a separate problem. But figuring out what poison value came from where and which values are already used is getting to be an ugly problem for the kernel itself.

Signature · 1 line
Mathematics is the supreme nostalgia of our time.