Skip to contentSkip to conversation

SubmittingPatches typo

PATCH Pavel Machek 10 participants 15 messages Mar 20, 2006 – Mar 22, 2006 Documentation

lore
Share & tools
lore
#0 lore raw

Hi!

I'm not 100% sure with my english, but this seems wrong...

Documentation/SubmittingPatches +1 -1
index c2c85bc..8fd6d4e 100644
@@ -490,7 +490,7 @@ NO!!!! No more huge patch bombs to linux
 Kernel Documentation/CodingStyle
   <http://sosdg.org/~coywolf/lxr/source/Documentation/CodingStyle>
 
-Linus Torvald's mail on the canonical patch format:
+Linus Torvalds' mail on the canonical patch format:
   <http://lkml.org/lkml/2005/4/7/183>
 --
 Last updated on 17 Nov 2005.
Signature · 1 line
Picture of sleeping (Linux) penguin wanted...
#1 lore raw

Documentation/SubmittingPatches NO!!!! No more huge patch bombs to linux · line 493

Quoted 8 lines

Hi!

I'm not 100% sure with my english, but this seems wrong...

Documentation/SubmittingPatches +1 -1
-Linus Torvald's mail on the canonical patch format:
+Linus Torvalds' mail on the canonical patch format:

Neither. (It would have been correct in German, though.) Correct is - in English:
Linus Torvalds's mail on the canonical patch format:

Jan Engelhardt

Signature · 1 line
| Software Engineer and Linux/Unix Network Administrator
#2 lore raw
Quoted 4 lines · Jan Engelhardt
Quoted 4 lines

Hi!

I'm not 100% sure with my english, but this seems wrong...

Quoted 9 lines

Documentation/SubmittingPatches NO!!!! No more huge patch bombs to linux · line 493

Quoted 4 lines
Documentation/SubmittingPatches +1 -1
-Linus Torvald's mail on the canonical patch format:
+Linus Torvalds' mail on the canonical patch format:

Neither. (It would have been correct in German, though.) Correct is - in English:
Linus Torvalds's mail on the canonical patch format:

I agree with Pavel. i think its a rule in english that when the word ends with s, you dont repeat another s after the '

#3 lore raw
Quoted 14 lines · Matheus Izvekov
Quoted 4 lines · Jan Engelhardt
Quoted 4 lines

Hi!

I'm not 100% sure with my english, but this seems wrong...

Quoted 8 lines

Documentation/SubmittingPatches NO!!!! No more huge patch bombs to linux · line 493

Quoted 4 lines
Documentation/SubmittingPatches +1 -1
-Linus Torvald's mail on the canonical patch format:
+Linus Torvalds' mail on the canonical patch format:

Neither. (It would have been correct in German, though.) Correct is - in English:
Linus Torvalds's mail on the canonical patch format:

Quoted 2 lines

I agree with Pavel. i think its a rule in english that when the word ends with s, you dont repeat another s after the '

When a word ends with an 's' *because it is plural* (i.e. the s denotes plurality) then you omit the second 's'. If the word ends with 's' in singular form you do the whole whack: ..s's.

I can't quote a source for this, but it's something I've known for years.

HTH,
Chris

Signature · 3 lines
Chris Boot
[email protected]
http://www.bootc.net/
#4 lore raw
Quoted 15 lines · Chris Boot
Quoted 14 lines · Matheus Izvekov
Quoted 12 lines · Jan Engelhardt

Documentation/SubmittingPatches NO!!!! No more huge patch bombs to linux · line 493

Quoted 8 lines

Hi!

I'm not 100% sure with my english, but this seems wrong...

Documentation/SubmittingPatches +1 -1
-Linus Torvald's mail on the canonical patch format:
+Linus Torvalds' mail on the canonical patch format:

Neither. (It would have been correct in German, though.) Correct is - in English:
Linus Torvalds's mail on the canonical patch format:

Quoted 8 lines
Quoted 2 lines

I agree with Pavel. i think its a rule in english that when the word ends with s, you dont repeat another s after the '

When a word ends with an 's' *because it is plural* (i.e. the s denotes plurality) then you omit the second 's'. If the word ends with 's' in singular form you do the whole whack: ..s's.

I can't quote a source for this, but it's something I've known for years.

Ok, if you are native speaker, I trust you. Could you send a patch to akpm?
Pavel

Signature · 1 line
Picture of sleeping (Linux) penguin wanted...
#5 lore raw
In reply to Chris Boot
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

Documentation/SubmittingPatches NO!!!! No more huge patch bombs to linux · line 493

Quoted 3 lines
Documentation/SubmittingPatches +1 -1
-Linus Torvald's mail on the canonical patch format:
+Linus Torvalds' mail on the canonical patch format:

Neither. (It would have been correct in German, though.) Correct is - in English:
Linus Torvalds's mail on the canonical patch format:

Quoted 9 lines
Quoted 2 lines

I agree with Pavel. i think its a rule in english that when the word ends with s, you dont repeat another s after the '

When a word ends with an 's' *because it is plural* (i.e. the s denotes plurality) then you omit the second 's'. If the word ends with 's' in singular form you do the whole whack: ..s's.

I can't quote a source for this, but it's something I've known for years.

http://en.wikipedia.org/wiki/Genitive

Jan Engelhardt

#6 lore raw
Quoted 2 lines
Quoted 2 lines

When a word ends with an 's' *because it is plural* (i.e. the s denotes plurality) then you omit the second 's'. If the word ends with 's'

in singular

Quoted 6 lines
Quoted 3 lines

form you do the whole whack: ..s's.

I can't quote a source for this, but it's something I've known for years.

http://en.wikipedia.org/wiki/Genitive

here is an excerpt from that link:

Genitive of origin; subjective genitive

* Beethoven's music
* Fred Astaire's dancing
* Confucius' teaching

Confucius is a name ending with s jus like Torvalds is, its not plural form of anything.

#7 lore raw
In reply to Jan Engelhardt
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Quoted 5 lines

Documentation/SubmittingPatches NO!!!! No more huge patch bombs to linux · line 493

Quoted 2 lines
Documentation/SubmittingPatches +1 -1
-Linus Torvald's mail on the canonical patch format:
+Linus Torvalds' mail on the canonical patch format:

Neither. (It would have been correct in German, though.) Correct is - in English:
Linus Torvalds's mail on the canonical patch format:

I agree with Pavel. i think its a rule in english that when the word ends with s, you dont repeat another s after the '

Quoted 8 lines
Quoted 5 lines

When a word ends with an 's' *because it is plural* (i.e. the s denotes plurality) then you omit the second 's'. If the word ends with 's' in singular form you do the whole whack: ..s's.

I can't quote a source for this, but it's something I've known for years.

http://en.wikipedia.org/wiki/Genitive

Anyway, I have a more authoritative source[1], which says

Singular
Kate's book
Father's pipe
Charles's records
Alice's cassettes
Plural
my parents' books
the boys' room
the children's toys
men's clothes

<Warning sign>
My friend's bike is new.
My friends' bikes are over there.

<Translated> With singular, an apostrophe and an s is added to the noun. As for plural forms with a trailing -s, only an apostrophe is added. Other plural forms get an apostrophe and an s (like with singular).

Family names ending in -s may either have apostrophe + S or just an apostrophe appended.

Mrs Jones's/Jones' hats
The Bates's/Bates' house

So in our Torvalds case, we have the option.

[1] Ungerer/Pasch/Lampater/Hellyer-Jones "Learning English, Grundgrammatik" isbn 3-12-511510-8 distributed by Klett

Jan Engelhardt

Signature · 1 line
| Software Engineer and Linux/Unix Network Administrator
#8 lore raw

Believe me, English Grammar is harder than trying to understand kernel code.

I was taught that 'ownership' and 'owner' decide, depending on the tense.

Fred's code (it's his - 'Fred has ['s] code')). - Here also "it's" is short for "it is" (sucking eggs).

Freds' code. You are talking third party about Freds' (or should that be Fred's?) code that he owns.

Names that end in 's' may not be plural... the Smiths family? Or the Smiths' Family? What happens if you are talking about 10 Smiths'/Smith's families? Smiths Families?

So, I think:

Torvald's code == Torvalds has code == Torvald's ['s == has]

Reference Torvalds' code = Torvalds[es]' code [owner]

This debate has been on this board been a few times... and with all the English masters in there, it is still a little bit unresolved.

http://www.b2g2.com/boards/board.cgi?user=dharrison

Stick to coding kernels guys, it's easier.

The fix?

+Here is the mail Linus Torvalds sent on the canonical patch format:

Nick

#9 lore raw
Quoted 16 lines · Nick Warne

Believe me, English Grammar is harder than trying to understand kernel code..

I was taught that 'ownership' and 'owner' decide, depending on the tense.

Fred's code (it's his - 'Fred has ['s] code')). - Here also "it's" is short for "it is" (sucking eggs).

Freds' code. You are talking third party about Freds' (or should that be Fred's?) code that he owns.

Names that end in 's' may not be plural... the Smiths family? Or the Smiths' Family? What happens if you are talking about 10 Smiths'/Smith's families? Smiths Families?

So, I think:

Quoted 8 lines

Torvald's code == Torvalds has code == Torvald's ['s == has]

Reference Torvalds' code = Torvalds[es]' code [owner]

This debate has been on this board been a few times... and with all the English masters in there, it is still a little bit unresolved.

http://www.b2g2.com/boards/board.cgi?user=dharrison

I think we'll all have to agree to disagree about this and nip it in the bud before everything gets out of hand!

Quoted 1 line

Stick to coding kernels guys, it's easier.

Agreed.

Quoted 3 lines

The fix?

+Here is the mail Linus Torvalds sent on the canonical patch format:

Ah, so simple, so nice. This one gets my vote.

Quoted 1 line

Nick

Chris

Signature · 3 lines
Chris Boot
[email protected]
http://www.bootc.net/
#10 lore raw
In reply to Matheus Izvekov
Quoted 15 lines · Matheus Izvekov
Quoted 4 lines · Jan Engelhardt
Quoted 4 lines

Hi!

I'm not 100% sure with my english, but this seems wrong...

Quoted 9 lines

Documentation/SubmittingPatches NO!!!! No more huge patch bombs to linux · line 493

Quoted 4 lines
Documentation/SubmittingPatches +1 -1
-Linus Torvald's mail on the canonical patch format:
+Linus Torvalds' mail on the canonical patch format:

Neither. (It would have been correct in German, though.) Correct is - in English:
Linus Torvalds's mail on the canonical patch format:

Quoted 2 lines

I agree with Pavel. i think its a rule in english that when the word ends with s, you dont repeat another s after the '

Nope. It's actually one of the amusing places where there *is* no rule. Plurals that end in s always get just the apostrophe. But for singular nouns that end in s, while I tend to think of "'s" as the default, some people like to drop the final s if the result ("Sophocles's") would otherwise sound awkward spoken aloud.

If you really can't stand the ambiguity, go for "Mail from Linus Torvalds on the canonical patch format:".

--b.

#11 lore raw
Quoted 5 lines

Nope. It's actually one of the amusing places where there *is* no rule. Plurals that end in s always get just the apostrophe. But for singular nouns that end in s, while I tend to think of "'s" as the default, some people like to drop the final s if the result ("Sophocles's") would otherwise sound awkward spoken aloud.

The definitive references have this to say

US English: Strunk and White says it should be "Torvalds's" and that the apostrophe alone is used only for ancient particularly biblical names ending in -es/is (eg Moses' laws)

UK English: The Oxford Guide To Style says

"Use 's after non-classical or non-classicizing personal names ending with an s or z sound). It also says that Torvalds' would be acceptable.

So both agree that

Torvalds's

is correct and that would appear to be the right choice to keep everyone both sides of the pond happy.

Jan: Care to submit an updated patch as the original is indeed wrong ?

Alan

#12 lore raw
Quoted 2 lines

Jan: Care to submit an updated patch as the original is indeed wrong ?

Here you go. On that occassion, I fixed one more of the Torvalds-related Genetives.

Documentation/DocBook/kernel-locking.tmpl +1 -1
diff --fast -Ndpru linux-2.6.16~/Documentation/DocBook/kernel-locking.tmpl linux-2.6.16-typofix/Documentation/DocBook/kernel-locking.tmpl
@@ -1916,7 +1916,7 @@ machines due to caching.
     <listitem>
      <para>
        <filename>Documentation/spinlocks.txt</filename>: 
-       Linus Torvalds' spinlocking tutorial in the kernel sources.
+       Linus Torvalds's spinlocking tutorial in the kernel sources.
      </para>
     </listitem>
 
Documentation/SubmittingPatches +1 -1
diff --fast -Ndpru linux-2.6.16~/Documentation/SubmittingPatches linux-2.6.16-typofix/Documentation/SubmittingPatches
@@ -490,7 +490,7 @@ NO!!!! No more huge patch bombs to linux
 Kernel Documentation/CodingStyle
   <http://sosdg.org/~coywolf/lxr/source/Documentation/CodingStyle>
 
-Linus Torvald's mail on the canonical patch format:
+Linus Torvalds's mail on the canonical patch format:
   <http://lkml.org/lkml/2005/4/7/183>
 --
 Last updated on 17 Nov 2005.

#<eof>

Jan Engelhardt

Signature · 1 line
| Software Engineer and Linux/Unix Network Administrator
#13 lore raw
In reply to Alan Cox
Quoted 8 lines · Alan Cox
Quoted 7 lines

Nope. It's actually one of the amusing places where there *is* no rule. Plurals that end in s always get just the apostrophe. But for singular nouns that end in s, while I tend to think of "'s" as the default, some people like to drop the final s if the result ("Sophocles's") would otherwise sound awkward spoken aloud.

Quoted 7 lines

The definitive references have this to say

US English: Strunk and White says it should be "Torvalds's" and that the apostrophe alone is used only for ancient particularly biblical names ending in -es/is (eg Moses' laws)

akpm is already saying "Linus's" in his *mm-commits*:

This patch was probably dropped from -mm because
it has already been merged into a subsystem tree
or into Linus's tree

(btw, when Americans made mistakes, their English became American English.)

Quoted 26 lines

UK English: The Oxford Guide To Style says

"Use 's after non-classical or non-classicizing personal names ending with an s or z sound). It also says that Torvalds' would be acceptable.

So both agree that

Torvalds's

is correct and that would appear to be the right choice to keep everyone both sides of the pond happy.

Jan: Care to submit an updated patch as the original is indeed wrong ?

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#14 lore raw
In reply to Pavel Machek

Hi.

Quoted 11 lines · Pavel Machek

Hi!

I'm not 100% sure with my english, but this seems wrong...

(quoted diff) +0 -0

b/Documentation/SubmittingPatches index c2c85bc..8fd6d4e 100644

Documentation/SubmittingPatches NO!!!! No more huge patch bombs to linux · line 496

Quoted 8 lines
Documentation/SubmittingPatches +1 -1
@@ -490,7 +490,7 @@ NO!!!! No more huge patch bombs to linux
 Kernel Documentation/CodingStyle
   <http://sosdg.org/~coywolf/lxr/source/Documentation/CodingStyle>
 
-Linus Torvald's mail on the canonical patch format:
+Linus Torvalds' mail on the canonical patch format:
   <http://lkml.org/lkml/2005/4/7/183>
 --
 Last updated on 17 Nov 2005.

I read all the other messages, and still felt I needed to reply :).

This patch is correct. If a name ends in an s, the possessive form simply gets an apostrophe.

Plurals are irrelevant to the discussion, but I'll answer another part of the thread too. If you wanted to say that something belonged to Linus and his family, you'd still do Torvalds', and get the fact that Torvalds was in the plural from other words in the context (if possible).

Regards,

Nigel