Skip to contentSkip to conversation

cpufrequtils-001 released

ANNOUNCE New Dominik Brodowski 2 participants 5 messages Mar 26, 2006 – Apr 9, 2006 Kbuild

lore
Share & tools
lore
#0 lore raw

Hi!

cpufrequtils-001 (which is newer than cpufrequtils-0.4) is released and available at

http://www.kernel.org/pub/linux/utils/kernel/cpufreq/

See also:
http://www.kernel.org/pub/linux/utils/kernel/cpufreq/cpufrequtils.html

The most important change in this release is that the building does no longer depend on the autotools but on plain Makefiles. Thanks for all the input I received following the release of the RFC tarball 0.5-pre1.

Dominik

#1 lore raw

PATCH 1/1 really use STRIPCMD

On Sun, Mar 26, 2006 at 12:12:31PM +0200, Dominik Brodowski wrote:
[...]

Quoted 2 lines

longer depend on the autotools but on plain Makefiles. Thanks for all the input I received following the release of the RFC tarball 0.5-pre1.

Hello Dominik,
unfortunately it seems we did miss something :)
The attached (trivial) patch makes the build script really use STRIPCMD, besides defining it.

Signature · 2 lines
mattia
:wq!
Makefile +1 -1
@@ -192,7 +192,7 @@
 cpufreq-%: $(UTIL_OBJS)
 	$(QUIET) $(CC) $(CFLAGDEF) $(CFLAGS) -g -I. -I./lib/ -c -o utils/[email protected] utils/$*.c
 	$(QUIET) $(CC) $(CFLAGDEF) $(CFLAGS) -g -I./lib/ -L. -L./.libs/ -lcpufreq -o $@ utils/[email protected]
-	$(STRIP) $@
+	$(STRIPCMD) $@
 
 utils: cpufreq-info cpufreq-set
 

_______________________________________________
Cpufreq mailing list
[email protected]
http://lists.linux.org.uk/mailman/listinfo/cpufreq

#2 lore raw

PATCH 1/1 add a newline

In reply to Dominik Brodowski

Hello,

one more patch, I'm really sorry I actually had it pending around here for some time but totally forgot to send it... here it is. It simply adds a new line to an error message, I also updated the po's files.

bye

Signature · 2 lines
mattia
:wq!
utils/set.c +1 -1
@@ -279,7 +279,7 @@
 		struct cpufreq_policy *cur_pol = cpufreq_get_policy(cpu);
 		struct cpufreq_policy new_pol;
 		if (!cur_pol) {
-			printf(gettext ("wrong, unknown or unhandled CPU?"));
+			printf(gettext ("wrong, unknown or unhandled CPU?\n"));
 			return -EINVAL;
 		}
 
po/de.po +2 -2
diff -u cpufrequtils-001/po/de.po cpufrequtils-001.dirty/po/de.po
@@ -340,8 +340,8 @@
 
 #: utils/set.c:282
 #, c-format
-msgid "wrong, unknown or unhandled CPU?"
-msgstr "unbekannte oder nicht regelbare CPU"
+msgid "wrong, unknown or unhandled CPU?\n"
+msgstr "unbekannte oder nicht regelbare CPU\n"
 
 #: utils/set.c:306
 #, c-format
po/fr.po +2 -2
diff -u cpufrequtils-001/po/fr.po cpufrequtils-001.dirty/po/fr.po
@@ -329,8 +329,8 @@
 
 #: utils/set.c:282
 #, c-format
-msgid "wrong, unknown or unhandled CPU?"
-msgstr "CPU inconnu ou non support? ?"
+msgid "wrong, unknown or unhandled CPU?\n"
+msgstr "CPU inconnu ou non support? ?\n"
 
 #: utils/set.c:306
 #, c-format
po/it.po +2 -2
diff -u cpufrequtils-001/po/it.po cpufrequtils-001.dirty/po/it.po
@@ -337,8 +337,8 @@
 
 #: utils/set.c:282
 #, c-format
-msgid "wrong, unknown or unhandled CPU?"
-msgstr "CPU errata, sconosciuta o non gestita?"
+msgid "wrong, unknown or unhandled CPU?\n"
+msgstr "CPU errata, sconosciuta o non gestita?\n"
 
 #: utils/set.c:306
 #, c-format

_______________________________________________
Cpufreq mailing list
[email protected]
http://lists.linux.org.uk/mailman/listinfo/cpufreq

#3 lore raw
In reply to Dominik Brodowski

Hello Dominik,

I have on more patch to discuss :) (sorry, I know you're very busy, and please forgive me if I didn't respect your m-f-t previously).

The current Makefile doesn't allow an user to define his own CFLAGS without breaking the build completely. The attached patch addresses it (it could be done differently by defining a new variable and leaving CFLAGS and CFLAGDEF untouched, let me know if you prefer this approach).

Thanks

Signature · 2 lines
mattia
:wq!
Makefile +6 -6
@@ -125,16 +125,16 @@
 LIB_OBJS = 	lib/cpufreq.c lib/proc.c lib/sysfs.c
 LIB_PARTS = 	lib/cpufreq.lo
 
-CFLAGS :=	-pipe
+CFLAGDEF +=	-pipe
 
 ifeq ($(strip $(PROC)),true)
 	LIB_PARTS += lib/proc.lo
-	CFLAGS += -DINTERFACE_PROC
+	CFLAGDEF += -DINTERFACE_PROC
 endif
 
 ifeq ($(strip $(SYSFS)),true)
 	LIB_PARTS += lib/sysfs.lo
-	CFLAGS += -DINTERFACE_SYSFS
+	CFLAGDEF += -DINTERFACE_SYSFS
 	LDFLAGS = -lsysfs
 endif
 
@@ -158,10 +158,10 @@
 
 # if DEBUG is enabled, then we do not strip or optimize
 ifeq ($(strip $(DEBUG)),true)
-	CFLAGS  += -O1 -g -DDEBUG
+	CFLAGDEF  += -O1 -g -DDEBUG
 	STRIPCMD = /bin/true -Since_we_are_debugging
 else
-	CFLAGS  += $(OPTIMIZATION) -fomit-frame-pointer
+	CFLAGDEF  += $(OPTIMIZATION) -fomit-frame-pointer
 	STRIPCMD = $(STRIP) -s --remove-section=.note --remove-section=.comment
 endif
 
@@ -177,7 +177,7 @@
 	@$(HOSTCC) -O1 build/ccdv.c -o build/ccdv
 
 %.lo: $(LIB_OBJS) $(LIB_HEADERS)
-	$(QUIET) $(LIBTOOL) $(LIBTOOL_OPT) --mode=compile $(CC) $(CFLAGS) -o $@ -c $*.c
+	$(QUIET) $(LIBTOOL) $(LIBTOOL_OPT) --mode=compile $(CC) $(CFLAGDEF) $(CFLAGS) -o $@ -c $*.c
 
 libcpufreq.la: $(LIB_OBJS) $(LIB_HEADERS) $(LIB_PARTS) Makefile
 	@if [ $(strip $(SYSFS)) != true -a $(strip $(PROC)) != true ]; then \

_______________________________________________
Cpufreq mailing list
[email protected]
http://lists.linux.org.uk/mailman/listinfo/cpufreq

#4 lore raw

PATCH 1/1 sanitize rpath and quieten the strip command

In reply to Dominik Brodowski

Hello Dominik,

one more patch addressing two issues (one hunk each):

1 - use ccdv to run strip (yes, a really cosmetic change)

2 - use the proper rpath when linking libcpufreq.so. It is needed
because otherwise libtool will create a messed libdir in libcpufreq.la fooling 3rd parties linking against libcpufreq (and using libtool for themselves).
Since the problem is the usage of $(DESTDIR) this will probably only show in prebuilt packages in linux distros.

Eg: building cpufrequtils in /tmp/cpufrequtils-001/ and willing to install in /tmp/package

# cd /tmp/cpufrequtils-001/ && make DESTDIR=/tmp/package
...
# grep libdir /tmp/cpufrequtils-001/libcpufreq.la
libdir='/tmp/package/usr/lib'

I suppose this is definitely not the wanted behaviour.

Thanks

Signature · 2 lines
mattia
:wq!
Makefile +2 -2
@@ -185,14 +185,14 @@ libcpufreq.la: $(LIB_OBJS) $(LIB_HEADERS
 		exit -1; \
 	fi;
 	$(QUIET) $(LIBTOOL) $(LIBTOOL_OPT) --mode=link $(CC) $(CFLAGDEF) $(CFLAGS) $(LDFLAGS) -o libcpufreq.la -rpath \
-		$(DESTDIR)${libdir} -version-info $(LIB_VERSION) $(LIB_PARTS)
+		${libdir} -version-info $(LIB_VERSION) $(LIB_PARTS)
 
 libcpufreq: libcpufreq.la
 
 cpufreq-%: $(UTIL_OBJS)
 	$(QUIET) $(CC) $(CFLAGDEF) $(CFLAGS) -g -I. -I./lib/ -c -o utils/[email protected] utils/$*.c
 	$(QUIET) $(CC) $(CFLAGDEF) $(CFLAGS) -g -I./lib/ -L. -L./.libs/ -lcpufreq -o $@ utils/[email protected]
-	$(STRIPCMD) $@
+	$(QUIET) $(STRIPCMD) $@
 
 utils: cpufreq-info cpufreq-set
 

_______________________________________________
Cpufreq mailing list
[email protected]
http://lists.linux.org.uk/mailman/listinfo/cpufreq