net: drop duplicate assignment in request_sock
Subsystems (3)
PATCH 1/1 net: drop duplicate assignment in request_sock
From: Norbert Kiesel <[email protected]>
Just noticed that request_sock.[ch] contain a useless assignment of rskq_accept_head to itself. I assume this is a typo and the 2nd one was supposed to be _tail. However, setting _tail to NULL is not needed, so the patch below just drops the 2nd assignment.
---
This patch was sent by Norbert Kiesel on:
- 5 Mar 2006
include/net/request_sock.h +1 -1
@@ -145,7 +145,7 @@ {struct request_sock *req = queue->rskq_accept_head; - queue->rskq_accept_head = queue->rskq_accept_head =NULL ; + queue->rskq_accept_head =NULL ;return req; }
net/core/request_sock.c +1 -1
@@ -51,7 +51,7 @@get_random_bytes (&lopt->hash_rnd,sizeof (lopt->hash_rnd));rwlock_init (&queue->syn_wait_lock); - queue->rskq_accept_head = queue->rskq_accept_head =NULL ; + queue->rskq_accept_head =NULL ; lopt->nr_table_entries = nr_table_entries;write_lock_bh (&queue->syn_wait_lock);
From: Adrian Bunk <[email protected]>
Date: Sun, 26 Mar 2006 14:24:10 +0200
Quoted 9 lines
From: Norbert Kiesel <[email protected]>
Just noticed that request_sock.[ch] contain a useless assignment of
rskq_accept_headto itself. I assume this is a typo and the 2nd one was supposed to be_tail. However, setting_tailto NULL is not needed, so the patch below just drops the 2nd assignment.Signed-off-by Norbert Kiesel <[email protected]>Signed-off-by Adrian Bunk <[email protected]>
Applied, thanks.