ISDN: fix a few resource leaks in sc_ioctl()
PATCH 1/1 ISDN: fix a few resource leaks in sc_ioctl()
Fix a few resource leaks in drivers/isdn/sc/ioctl.c::sc_ioctl()
Signed-off-by Jesper Juhl <[email protected]>
---
drivers/isdn/sc/ioctl.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
drivers/isdn/sc/ioctl.c +5 -4
@@ -46,7 +46,8 @@ int sc_ioctl(int card, scs_ioctl *data)pr_debug ("%s: SCIOCRESET: ioctl received\n" , sc_adapter[card]->devicename); sc_adapter[card]->StartOnReset =0 ; -return (reset (card)); +kfree (rcvmsg); +return reset (card); }case SCIOCLOAD :
@@ -183,7 +184,7 @@ int sc_ioctl(int card, scs_ioctl *data) sc_adapter[card]->devicename); spid =kmalloc (SCIOC_SPIDSIZE ,GFP_KERNEL ); -if (!spid) { +if (!spid) {kfree (rcvmsg);return -ENOMEM ; }
@@ -195,10 +196,10 @@ int sc_ioctl(int card, scs_ioctl *data)if (!status) {pr_debug ("%s: SCIOCGETSPID: command successful\n" , sc_adapter[card]->devicename); - } -else { + }else {pr_debug ("%s: SCIOCGETSPID: command failed (status = %d)\n" , sc_adapter[card]->devicename, status); +kfree (spid);kfree (rcvmsg);return status; }
Quoted 5 lines · Jesper Juhl
Fix a few resource leaks in drivers/isdn/sc/ioctl.c::sc_ioctl()
Signed-off-by Jesper Juhl <[email protected]>
Acked-by Karsten Keil <[email protected]>
Quoted 41 lines
---
drivers/isdn/sc/ioctl.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)drivers/isdn/sc/ioctl.c +5
-4@@ -46,7 +46,8 @@ int sc_ioctl(int card, scs_ioctl *data)pr_debug ("%s: SCIOCRESET: ioctl received\n" , sc_adapter[card]->devicename); sc_adapter[card]->StartOnReset =0 ; -return (reset (card)); +kfree (rcvmsg); +return reset (card); }case SCIOCLOAD :@@ -183,7 +184,7 @@ int sc_ioctl(int card, scs_ioctl *data) sc_adapter[card]->devicename); spid =kmalloc (SCIOC_SPIDSIZE ,GFP_KERNEL ); -if (!spid) { +if (!spid) {kfree (rcvmsg);return -ENOMEM ; }@@ -195,10 +196,10 @@ int sc_ioctl(int card, scs_ioctl *data)if (!status) {pr_debug ("%s: SCIOCGETSPID: command successful\n" , sc_adapter[card]->devicename); - } -else { + }else {pr_debug ("%s: SCIOCGETSPID: command failed (status = %d)\n" , sc_adapter[card]->devicename, status); +kfree (spid);kfree (rcvmsg);return status; }
Signature · 3 lines
Karsten Keil SuSE Labs ISDN development