Skip to contentSkip to conversation

smp_locks reference_discarded errors

DISCUSSION Dave Jones 5 participants 9 messages Mar 25, 2006 – Mar 31, 2006

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

since the addition of smp alternatives, the following is occuring..

Error: ./drivers/md/md.o .smp_locks refers to 0000008c R_386_32 .exit.text
Error: ./drivers/usb/storage/libusual.o .smp_locks refers to 00000008 R_386_32 .exit.text
Error: ./net/802/psnap.o .smp_locks refers to 00000000 R_386_32 .exit.text
Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 00000008 R_386_32 .exit.text
Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 0000000c R_386_32 .exit.text

example .config at http://people.redhat.com/davej/kernel-2.6.16-i686-smp.config

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#1 lore raw
Quoted 11 lines · Dave Jones

since the addition of smp alternatives, the following is occuring..

Error: ./drivers/md/md.o .smp_locks refers to 0000008c R_386_32 .exit.text
Error: ./drivers/usb/storage/libusual.o .smp_locks refers to 00000008 R_386_32 .exit.text
Error: ./net/802/psnap.o .smp_locks refers to 00000000 R_386_32 .exit.text
Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 00000008 R_386_32 .exit.text
Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 0000000c R_386_32 .exit.text

example .config at http://people.redhat.com/davej/kernel-2.6.16-i686-smp.config

I guess an atomic operation in __exit code will cause that. down() and atomic_dec_and_test() in two cases.

I suspect most of these callsites are just wrongly coded - it's pretty unusual for __exit code to really need to lock anything - what is there to be racing against?

This is emitted by reference_discarded.pl?

author
#2 lore raw
Quoted 13 lines · Andrew Morton
Quoted 11 lines · Dave Jones

since the addition of smp alternatives, the following is occuring..

Error: ./drivers/md/md.o .smp_locks refers to 0000008c R_386_32 .exit.text
Error: ./drivers/usb/storage/libusual.o .smp_locks refers to 00000008 R_386_32 .exit.text
Error: ./net/802/psnap.o .smp_locks refers to 00000000 R_386_32 .exit.text
Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 00000008 R_386_32 .exit.text
Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 0000000c R_386_32 .exit.text

example .config at http://people.redhat.com/davej/kernel-2.6.16-i686-smp.config

Quoted 8 lines

I guess an atomic operation in __exit code will cause that. down() and atomic_dec_and_test() in two cases.

I suspect most of these callsites are just wrongly coded - it's pretty unusual for __exit code to really need to lock anything - what is there to be racing against?

This is emitted by reference_discarded.pl?

came out of a 'make buildcheck' a day or two ago (the following day, Sam nuked reference_discarded.pl in favour of it being done magically somewhere else (I've not looked into how its done now).

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#3 lore raw
Quoted 21 lines · Dave Jones
Quoted 20 lines · Andrew Morton
Quoted 11 lines · Dave Jones

since the addition of smp alternatives, the following is occuring..

Error: ./drivers/md/md.o .smp_locks refers to 0000008c R_386_32 .exit.text
Error: ./drivers/usb/storage/libusual.o .smp_locks refers to 00000008 R_386_32 .exit.text
Error: ./net/802/psnap.o .smp_locks refers to 00000000 R_386_32 .exit.text
Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 00000008 R_386_32 .exit.text
Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 0000000c R_386_32 .exit.text

example .config at http://people.redhat.com/davej/kernel-2.6.16-i686-smp.config

I guess an atomic operation in __exit code will cause that. down() and atomic_dec_and_test() in two cases.

I suspect most of these callsites are just wrongly coded - it's pretty unusual for __exit code to really need to lock anything - what is there to be racing against?

Quoted 5 lines
Quoted 1 line

This is emitted by reference_discarded.pl?

came out of a 'make buildcheck' a day or two ago (the following day, Sam nuked reference_discarded.pl in favour of it being done magically somewhere else (I've not looked into how its done now).

The check is part of modpost now. modpost is only used when building modules but that holds true for most builds anyway therefore I did not move it to a separate executable.

Also the output from modpost provides a bit more info.
So output from fresh -linus kernel would make it easier to locate the guilty stuff.

Sam

author
#4 lore raw
Quoted 3 lines · Sam Ravnborg

Also the output from modpost provides a bit more info.
So output from fresh -linus kernel would make it easier to locate the guilty stuff.

Finally coaxed latest -git to build on all archs I care about.. grab http://people.redhat.com/davej/buildlog.txt and grep for WARNING:
and see a zillion errors. The smp_locks ones seem to have disappeared now though.

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#5 lore raw
Quoted 10 lines · On Mon, 27 Mar 2006 19:04:18 -0500 Dave Jones wrote:
Quoted 3 lines · Sam Ravnborg

Also the output from modpost provides a bit more info.
So output from fresh -linus kernel would make it easier to locate the guilty stuff.

Finally coaxed latest -git to build on all archs I care about.. grab http://people.redhat.com/davej/buildlog.txt and grep for WARNING:
and see a zillion errors. The smp_locks ones seem to have disappeared now though.

I just posted a boatload of them to the kernel-janitors m-l also.

---
~Randy

#6 lore raw
In reply to Sam Ravnborg
Quoted 9 lines · Sam Ravnborg
Quoted 4 lines · Dave Jones

came out of a 'make buildcheck' a day or two ago (the following day, Sam nuked reference_discarded.pl in favour of it being done magically somewhere else (I've not looked into how its done now).

The check is part of modpost now. modpost is only used when building modules but that holds true for most builds anyway therefore I did not move it to a separate executable.
...

This doesn't sound good.

This means that we have no longer any tool that warns us about e.g. references from non-__exit code to __exit code [1]?

Quoted 1 line

Sam

cu
Adrian

[1] __exit, not __{dev,cpu,mem}exit

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#7 lore raw
Quoted 11 lines · Adrian Bunk
Quoted 9 lines · Sam Ravnborg
Quoted 4 lines · Dave Jones

came out of a 'make buildcheck' a day or two ago (the following day, Sam nuked reference_discarded.pl in favour of it being done magically somewhere else (I've not looked into how its done now).

The check is part of modpost now. modpost is only used when building modules but that holds true for most builds anyway therefore I did not move it to a separate executable.
...

Quoted 5 lines

This doesn't sound good.

This means that we have no longer any tool that warns us about e.g. references from non-__exit code to __exit code [1]?
[1] __exit, not __{dev,cpu,mem}exit

It does warn for this also. The test I have carried out has mostly been on allmodconfig builds though. I assume you are worried for the case when a module is built-in and the __exit section is discarded - or?

Sam

#8 lore raw
Quoted 14 lines · Sam Ravnborg
Quoted 13 lines · Adrian Bunk
Quoted 9 lines · Sam Ravnborg
Quoted 4 lines · Dave Jones

came out of a 'make buildcheck' a day or two ago (the following day, Sam nuked reference_discarded.pl in favour of it being done magically somewhere else (I've not looked into how its done now).

The check is part of modpost now. modpost is only used when building modules but that holds true for most builds anyway therefore I did not move it to a separate executable.
...

This doesn't sound good.

Quoted 7 lines
Quoted 3 lines

This means that we have no longer any tool that warns us about e.g. references from non-__exit code to __exit code [1]?
[1] __exit, not __{dev,cpu,mem}exit

It does warn for this also. The test I have carried out has mostly been on allmodconfig builds though. I assume you are worried for the case when a module is built-in and the __exit section is discarded - or?

Exactly - especially since in kernel 2.6 we are getting on architectures like i386 no longer link errors as we did in kernel 2.4.

Perhaps I'm only concerned because my usual builds didn't produce a single warning... ;-)

Quoted 1 line

Sam

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed