Skip to contentSkip to conversation

powerpc: Fix some initcall return values

PATCH New Anton Blanchard 1 participant 1 message Mar 28, 2006 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Fix some initcall return values

Non zero initcalls (except for -ENODEV) have started warning at boot. Fix smt_setup and init_ras_IRQ.

---

arch/powerpc/kernel/sysfs.c +3 -3
Index: build/arch/powerpc/kernel/sysfs.c
===================================================================
@@ -65,11 +65,11 @@ static int __init smt_setup(void)
 	unsigned int cpu;
 
 	if (!cpu_has_feature(CPU_FTR_SMT))
-		return 1;
+		return -ENODEV;
 
 	options = find_path_device("/options");
 	if (!options)
-		return 1;
+		return -ENODEV;
 
 	val = (unsigned int *)get_property(options, "ibm,smt-snooze-delay",
 					   NULL);
@@ -78,7 +78,7 @@ static int __init smt_setup(void)
 			per_cpu(smt_snooze_delay, cpu) = *val;
 	}
 
-	return 1;
+	return 0;
 }
 __initcall(smt_setup);
 
arch/powerpc/platforms/pseries/ras.c +1 -1
Index: build/arch/powerpc/platforms/pseries/ras.c
===================================================================
@@ -132,7 +132,7 @@ static int __init init_ras_IRQ(void)
 		of_node_put(np);
 	}
 
-	return 1;
+	return 0;
 }
 __initcall(init_ras_IRQ);