Janitor: drivers/net/pcnet32: fix incorrect comments
Subsystems (2)
PATCH 1/1 Janitor: drivers/net/pcnet32: fix incorrect comments
Please sign-off/ack/apply and/or forward upstream.
[PATCH] Janitor: drivers/net/pcnet32: fix incorrect comments
The comments concerning how the pcnet32 ethernet device driver selects the MAC addr to use are incorrect. A recent patch (in the last 3 months) changed how the code worked, but did not change the comments.
Side comment: the new behaviour is good; I've got a pcnet32 card which powers up with garbage in the CSR's, and a good MAC addr in the PROM.
----
drivers/net/pcnet32.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/pcnet32.c +2 -2
@@ -1167,8 +1167,8 @@ pcnet32_probe1(unsigned long ioaddr, int* station address PROM at the base address and programmed into the * "Physical Address Registers" CSR12-14. * As a precautionary measure, we read the PROM values and complain if -* they disagree with the CSRs. Either way, we use the CSR values, and -* double check that they are valid. +* they disagree with the CSRs. If they miscompare, and the PROM addr +* is valid, then the PROM addr is used. */ for (i =0 ; i <3 ; i++) {unsigned int val;
Jeff Garzik
AppliedQuoted 11 lines · Linas Vepstas
Please sign-off/ack/apply and/or forward upstream.
[PATCH] Janitor:
drivers/net/pcnet32: fix incorrect commentsThe comments concerning how the pcnet32 ethernet device driver selects the MAC addr to use are incorrect. A recent patch (in the last 3 months) changed how the code worked, but did not change the comments.
Side comment: the new behaviour is good; I've got a pcnet32 card which powers up with garbage in the CSR's, and a good MAC addr in the PROM.
Signed-off-by Linas Vepstas <[email protected]>
applied